Skip to content

refactor to reuse TraceProvider #3548

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
ggamsso wants to merge 2 commits into
base: main
Choose a base branch
from
Open

refactor to reuse TraceProvider #3548

Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
f8c980a
refactor to reuse TraceProvider
ggamsso Nov 13, 2025
9283d38
Update adk_web_server.py
ggamsso Nov 14, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 7 additions & 2 deletions src/google/adk/cli/adk_web_server.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -294,11 +294,16 @@ def _setup_telemetry(
)
else:
# Old logic - to be removed when above leaves experimental.
tracer_provider = TracerProvider()
requires_set_trace_provider = False
tracer_provider = trace.get_tracer_provider()
if isinstance(tracer_provider, trace.ProxyTracerProvider):
requires_set_trace_provider = True
tracer_provider = TracerProvider()
if internal_exporters is not None:
for exporter in internal_exporters:
tracer_provider.add_span_processor(exporter)
trace.set_tracer_provider(tracer_provider=tracer_provider)
if requires_set_trace_provider:
trace.set_tracer_provider(tracer_provider=tracer_provider)
Comment thread
ggamsso marked this conversation as resolved.
Outdated


def _otel_env_vars_enabled() -> bool:
Expand Down