Skip to content

fix: resolve CI test failures for Redis temp state and S3 deps #125

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
miyannishar wants to merge 2 commits into
base: main
Choose a base branch
from
Open

fix: resolve CI test failures for Redis temp state and S3 deps #125

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
eaa1942
fix: resolve CI test failures for Redis temp state and S3 deps
miyannishar May 5, 2026
7384a6d
fix: remove non-existent --extra s3 from CI workflow
miyannishar May 5, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion .github/workflows/unit-tests.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -31,7 +31,7 @@ jobs:
uv venv .venv
source .venv/bin/activate
# Install dependencies as recommended in CONTRIBUTING.md
uv sync --extra test
uv sync --extra test

- name: Run unit tests with pytest
run: |
Expand Down
7 changes: 7 additions & 0 deletions src/google/adk_community/sessions/redis_session_service.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -197,6 +197,13 @@ async def append_event(self, session: Session, event: Event) -> Event:
await super().append_event(session=session, event=event)
session.last_update_time = event.timestamp

# Defensively strip temp state so it is never persisted to Redis.
temp_keys = [
k for k in session.state if k.startswith(State.TEMP_PREFIX)
]
for k in temp_keys:
del session.state[k]

async with self.cache.pipeline(transaction=False) as pipe:
user_sessions_key = RedisKeys.user_sessions(
session.app_name, session.user_id
Expand Down