Skip to content

Extract timestamp as double for InMemorySessionService events #956

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
tlanclos wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Extract timestamp as double for InMemorySessionService events #956

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions core/src/main/java/com/google/adk/sessions/InMemorySessionService.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -163,8 +163,8 @@ public Maybe<Session> getSession(
}

// Helper to get event timestamp as epoch seconds
private long getEventTimestampEpochSeconds(Event event) {
return event.timestamp() / 1000L;
private double getEventTimestampEpochSeconds(Event event) {
return event.timestamp() / 1000.0;
}

@Override
Expand Down
19 changes: 19 additions & 0 deletions core/src/test/java/com/google/adk/sessions/InMemorySessionServiceTest.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -20,6 +20,7 @@
import com.google.adk.events.Event;
import com.google.adk.events.EventActions;
import io.reactivex.rxjava3.core.Single;
import java.time.Instant;
import java.util.HashMap;
import java.util.Optional;
import java.util.concurrent.ConcurrentHashMap;
Expand Down Expand Up @@ -214,6 +215,24 @@ public void appendEvent_removesState() {
assertThat(retrievedSessionRemove.state()).doesNotContainKey("temp:tempKey");
}

@Test
public void appendEvent_updatesSessionTimestampWithFractionalSeconds() {
InMemorySessionService sessionService = new InMemorySessionService();
Session session =
sessionService.createSession("app", "user", new HashMap<>(), "session1").blockingGet();

// Add an event with a timestamp that contains a fractional second
Event eventAdd = Event.builder().timestamp(5500).build();
var unused = sessionService.appendEvent(session, eventAdd).blockingGet();

// Verify the last modified timestamp contains a fractional second
Session retrievedSession =
sessionService
.getSession(session.appName(), session.userId(), session.id(), Optional.empty())
.blockingGet();
assertThat(retrievedSession.lastUpdateTime()).isEqualTo(Instant.ofEpochSecond(5, 500000000L));
}

@Test
public void sequentialAgents_shareTempState() {
InMemorySessionService sessionService = new InMemorySessionService();
Expand Down