Skip to content

Conversation

@AkshatG6
Copy link
Contributor

@AkshatG6 AkshatG6 commented Jan 26, 2026

This PR adds unit tests for the AMR claim within GIDSignInTest.

It also includes a refactor of existing tests to improve maintainability and scalability:

  • Updates existing tests in GIDSignInTest and OIDTokenResponse + Testing for a cleaner codebase.
  • Removes testInstanceWithIDToken...authTime:(NSString *)authTime... as no intended usage was found.
  • Updates fatIDTokenWithAuthTime to fatIDTokenWithClaims to better reflect its behavior.
  • Renames existing tests and parameters (e.g., authTime to claims) to allow tests to be more easily extended in the future.

@AkshatG6 AkshatG6 requested a review from mdmathias January 26, 2026 17:58
@AkshatG6 AkshatG6 requested a review from mdmathias January 26, 2026 18:37
@AkshatG6 AkshatG6 merged commit bd48ccb into gandhiakshat/sbc-amr-main Jan 26, 2026
13 checks passed
@AkshatG6 AkshatG6 deleted the gandhiakshat/sbc-amr-additional-tests branch January 26, 2026 21:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants