Skip to content

Resolved The app icon set AppIcon has an unassigned child warning…#348

Merged
w-goog merged 7 commits intogoogle:mainfrom
cho407:main
Mar 18, 2026
Merged

Resolved The app icon set AppIcon has an unassigned child warning…#348
w-goog merged 7 commits intogoogle:mainfrom
cho407:main

Conversation

@cho407
Copy link
Contributor

@cho407 cho407 commented Nov 13, 2023

While reviewing the sample code, I noticed the warning 'The app icon set "AppIcon" has an unassigned child'. Concerned that this might undermine the integrity of the example, I made a minor adjustment. I found that a 1024x1024 size Mac icon was unassigned, so I moved it to the correct size slot. If my modification is appropriate, I kindly request a merge. Have a great day! :)

cho407 and others added 2 commits November 13, 2023 21:09
@w-goog
Copy link
Contributor

w-goog commented Mar 5, 2026

Thank you for this contribution! If you could update your branch and ensure you've accepted the CLA, we'd be happy to get this one in :)

@cho407
Copy link
Contributor Author

cho407 commented Mar 5, 2026

I have updated the branch and accepted the CLA. Thanks for your comment

@w-goog w-goog self-requested a review March 11, 2026 20:24
@cho407 cho407 changed the title Resolved 'The app icon set "AppIcon" has an unassigned child' warning… Resolved The app icon set AppIcon has an unassigned child warning… Mar 11, 2026
@cho407
Copy link
Contributor Author

cho407 commented Mar 11, 2026

Thanks for the approval. I realized after updating the branch that the double quotes in the PR title could have caused an issue with the JSON payload for the Google Chat notification workflow. I’ve updated the PR title, but I’m not entirely sure whether the change was reflected properly. I’d appreciate it if you could approve it again. Hope you have a great day:)

@w-goog
Copy link
Contributor

w-goog commented Mar 18, 2026

Sweet of you, thank you! That one doesn't work for other reasons, all good :) Will re-run and then merge.

@cho407
Copy link
Contributor Author

cho407 commented Mar 18, 2026

Thanks for resolving problem:) You made my day! 👍

@w-goog w-goog merged commit 6ad8c90 into google:main Mar 18, 2026
13 checks passed
@w-goog
Copy link
Contributor

w-goog commented Mar 18, 2026

Of course! Thank you for contributing 🥰

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants