Resolved The app icon set AppIcon has an unassigned child warning…#348
Resolved The app icon set AppIcon has an unassigned child warning…#348w-goog merged 7 commits intogoogle:mainfrom
Conversation
… by replacing the Mac icon image in the 'AppIcon' asset set.
|
Thank you for this contribution! If you could update your branch and ensure you've accepted the CLA, we'd be happy to get this one in :) |
|
I have updated the branch and accepted the CLA. Thanks for your comment |
|
Thanks for the approval. I realized after updating the branch that the double quotes in the PR title could have caused an issue with the JSON payload for the Google Chat notification workflow. I’ve updated the PR title, but I’m not entirely sure whether the change was reflected properly. I’d appreciate it if you could approve it again. Hope you have a great day:) |
|
Sweet of you, thank you! That one doesn't work for other reasons, all good :) Will re-run and then merge. |
|
Thanks for resolving problem:) You made my day! 👍 |
|
Of course! Thank you for contributing 🥰 |
While reviewing the sample code, I noticed the warning 'The app icon set "AppIcon" has an unassigned child'. Concerned that this might undermine the integrity of the example, I made a minor adjustment. I found that a 1024x1024 size Mac icon was unassigned, so I moved it to the correct size slot. If my modification is appropriate, I kindly request a merge. Have a great day! :)