fix(vscode-ide-companion): stop leaking gemini.diff.accept and onDidChangeWorkspaceFolders disposables

[godququ5-code]

Summary

Fixes #27790.

The two context.subscriptions.push(...) calls in activate() wrapped a pair of registrations in a stray parenthesis pair, collapsing them into a comma expression whose value was only the last operand. As a result the gemini.diff.accept command Disposable and the onDidChangeWorkspaceFolders listener Disposable were created but never added to context.subscriptions, so they were never disposed on deactivation. On re-activation within the same extension host this threw command 'gemini.diff.accept' already exists, and the stale onDidChangeWorkspaceFolders listener kept firing ideServer.syncEnvVars() against a stopped IDEServer.

• Removed the extra parentheses so each registration is its own argument to push().
• Added a regression test in extension.test.ts that tags the created Disposables and asserts both gemini.diff.accept and onDidChangeWorkspaceFolders land in context.subscriptions.

Test plan

• cd packages/vscode-ide-companion && npm test (vitest): new test in extension.test.ts passes; existing tests unaffected.

[gemini-code-assist]

Summary of Changes

Hello, I'm Gemini Code Assist¹! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request addresses a resource leak issue where specific command and listener registrations were not being added to the extension's subscription list due to incorrect syntax. By removing the stray parentheses, these objects are now correctly tracked, ensuring they are properly disposed of during extension deactivation and preventing duplicate registration errors on re-activation.

Highlights

• Fixed Disposable Registration: Removed incorrect parentheses in context.subscriptions.push() calls that were causing comma expressions, preventing some Disposables from being tracked and disposed of correctly.
• Regression Testing: Added a new test case in extension.test.ts to verify that both the gemini.diff.accept command and the onDidChangeWorkspaceFolders listener are properly registered in context.subscriptions.

Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature	Command	Description
Code Review	/gemini review	Performs a code review for the current pull request in its current state.
Pull Request Summary	/gemini summary	Provides a summary of the current pull request in its current state.
Comment	@gemini-code-assist	Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help	/gemini help	Displays a list of available commands.

Customization

To customize the Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counterproductive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for GitHub and other Google products, sign up here.

Footnotes

1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution. ↩

[github-actions]

📊 PR Size: size/S

• Lines changed: 39
• Additions: +35
• Deletions: -4
• Files changed: 2

[gemini-code-assist]

Code Review

This pull request fixes a bug where certain VS Code command and listener registrations were wrapped in stray parentheses, causing them to be evaluated as comma expressions and preventing them from being tracked for disposal in context.subscriptions. A new test is added to verify that all created Disposables are correctly registered. The reviewer suggested using optional chaining when inspecting context.subscriptions in the test to avoid potential TypeError exceptions from undefined elements.

[gemini-code-assist]

Since some of the mocked VS Code APIs (such as onDidCloseTextDocument or registerTextDocumentContentProvider) return undefined by default in the test environment, context.subscriptions will contain undefined elements. Accessing d.command or d.kind directly on these elements will throw a TypeError: Cannot read properties of undefined. Use optional chaining (d?.command and d?.kind) to safely inspect the subscriptions.

Suggested change

	expect(pushed.some((d) => d.command === 'gemini.diff.accept')).toBe(true);
	expect(
	pushed.some((d) => d.kind === 'onDidChangeWorkspaceFolders'),
	).toBe(true);
	expect(pushed.some((d) => d?.command === 'gemini.diff.accept')).toBe(true);
	expect(
	pushed.some((d) => d?.kind === 'onDidChangeWorkspaceFolders'),
	).toBe(true);