Fix out-of-bounds access on invalid mjvCamera->fixedcamid#3311
Open
davidhozic wants to merge 1 commit into
Open
Fix out-of-bounds access on invalid mjvCamera->fixedcamid#3311davidhozic wants to merge 1 commit into
davidhozic wants to merge 1 commit into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The
mjv_updateCameramethod currently does bound checking for thefixedcamidonly after calling bothmjv_cameraFrameandmjv_cameraFrustum. Unlikemjv_cameraFrustum, themjv_cameraFramemethod does not do bound checking for thefixedcamid, which results in out-of-bounds access and thus undefined behavior, whenfixedcamidis outside the valid range.While the program will exit in error via
mjERRORmost of the time, this is still undefined behavior and can lead to random segmentation faults with no clear errors about what happened.This pull request fixes this by reordering the method calls, resulting in the fixed camera's ID being checked prior to first indexing. A redundant check was also removed in
mjv_updateCamera, becausemjv_cameraFrustumalready does the checking.