Skip to content

fix: fix USD loading for simulate (#3004, #3099)#3303

Open
nithin434 wants to merge 1 commit into
google-deepmind:mainfrom
nithin434:fix-usd-simulate
Open

fix: fix USD loading for simulate (#3004, #3099)#3303
nithin434 wants to merge 1 commit into
google-deepmind:mainfrom
nithin434:fix-usd-simulate

Conversation

@nithin434
Copy link
Copy Markdown

Route USD file extensions through the USD decoder and content-type mapping so drag-and-drop loads .usd/.usda/.usdc/.usdz instead of falling back to XML. #3004, #3099

…ind#3099)

Route USD file extensions through the USD decoder and content-type mapping so drag-and-drop loads .usd/.usda/.usdc/.usdz instead of falling back to XML.
@nithin434
Copy link
Copy Markdown
Author

@yuvaltassa @havess can you review it

Comment thread simulate/main.cc
mnew = mj_loadXML(filename, nullptr, loadError, kErrorLength);
} else {
mjSpec* spec = mj_parse(filename, nullptr, nullptr, loadError, kErrorLength);
mjSpec* spec = mj_parse(
Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

mj_parse will grab the file extension when loaded with no content_type and the usd decoder is registered with all 4 (usd, usdc, usda, usdz).

So I don't think this change is doing anything?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants