Accept numpy integers for rollout nstep and chunk_size#3300
Open
Nas01010101 wants to merge 1 commit into
Open
Conversation
`rollout` rejected `nstep` and `chunk_size` arguments whose type was a numpy integer (e.g. `np.int64`), because `isinstance(np.int64(3), int)` is `False`. These values commonly come from numpy operations such as `array.shape[i]`, so passing them raised `ValueError: nstep must be an integer` even though they are valid integers. Accept `numpy.integer` in addition to the built-in `int` for both checks. Adds a regression test passing `np.int64` for `nstep` and `chunk_size`; it fails before this change and passes after.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
rolloutrejectsnstepandchunk_sizearguments whose type is a numpy integer (e.g.np.int64):isinstance(np.int64(3), int)isFalse, so a numpy integer is rejected even though it is a valid integer. These values very commonly come from numpy operations (array.shape[i], products of dimensions,np.arange(...)[i], etc.), so this raisesValueError: nstep must be an integer:while the identical call with a Python
intworks.Fix
Accept
numpy.integerin addition to the built-inintfor both checks (numpyis already imported asnp). The downstream C++ call already handles the value numerically, so no other change is needed.Tests
Adds
test_numpy_integer_nstep_and_chunk_size, which callsrolloutwithnp.int64values fornstepandchunk_size. It fails before this change (ValueError) and passes after; the rest ofrollout_test.pyremains green.