Skip to content

[Unity] Switched from arbitrary to ID-based ordering when creating the scene#3267

Open
njfletcher215 wants to merge 1 commit into
google-deepmind:mainfrom
njfletcher215:order-siblings-deterministically
Open

[Unity] Switched from arbitrary to ID-based ordering when creating the scene#3267
njfletcher215 wants to merge 1 commit into
google-deepmind:mainfrom
njfletcher215:order-siblings-deterministically

Conversation

@njfletcher215
Copy link
Copy Markdown

No description provided.

@njfletcher215
Copy link
Copy Markdown
Author

Closes #3175

@Balint-H
Copy link
Copy Markdown
Collaborator

Heya! Thanks for looking into the issue! Have you ran the tests 10+ times with your fix? Weird request, I know, but in this issue the fail only happens on some occasions

@njfletcher215
Copy link
Copy Markdown
Author

No problem! Yes, each test passed 20/20 iterations.

For reference, before the fix both tests were about 50/50:

  • MjcfHierarchyMirrorsTheHierarchy passed 11/20 iterations
  • SceneRecreatedAfterDeletion passed 9/20 iterations.

Copy link
Copy Markdown
Collaborator

@Balint-H Balint-H left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for double checking! Looks good to me. There is a very minor extra computation cost with the flag but it is a non-issue since CreateScene is called sparsely.

@yuvaltassa yuvaltassa changed the title Switched from arbitrary to ID-based ordering when creating the scene [Unity] Switched from arbitrary to ID-based ordering when creating the scene May 18, 2026
@yuvaltassa yuvaltassa added the Unity Unity plug-in label May 18, 2026
@Balint-H
Copy link
Copy Markdown
Collaborator

Balint-H commented May 18, 2026

LGTM, @erez-tom

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Unity Unity plug-in

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants