Fix MinGW printf format errors for size_t#3086
Open
Ashutosh0x wants to merge 1 commit intogoogle-deepmind:mainfrom
Open
Fix MinGW printf format errors for size_t#3086Ashutosh0x wants to merge 1 commit intogoogle-deepmind:mainfrom
Ashutosh0x wants to merge 1 commit intogoogle-deepmind:mainfrom
Conversation
MinGW-w64 on certain platforms does not correctly handle the %zu format specifier for size_t, leading to build errors when warnings are treated as errors. This change replaces %zu with %llu and casts the corresponding arguments to (unsigned long long) for better cross-platform compatibility. Fixes google-deepmind#3039
Collaborator
|
FYI, I have a different fix for this which I think better addresses the root issue, and doesn't require changing any of this code. I'll try to send it out tomorrow. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This Pull Request fixes build errors on MinGW toolchains that do not correctly support the %zu format specifier.
Changes
Fixes #3039