Fix MinGW stat redefinition and thread-safe localtime#3084
Open
Ashutosh0x wants to merge 1 commit intogoogle-deepmind:mainfrom
Open
Fix MinGW stat redefinition and thread-safe localtime#3084Ashutosh0x wants to merge 1 commit intogoogle-deepmind:mainfrom
Ashutosh0x wants to merge 1 commit intogoogle-deepmind:mainfrom
Conversation
- Guard #define stat _stat with !defined(__MINGW32__) to avoid conflicts with MinGW's own POSIX-compliant stat implementation - Replace _MSC_VER check with defined(_WIN32) for localtime_s to allow all Windows compilers including MinGW to use the secure function Fixes google-deepmind#3038, google-deepmind#3037
mmossg
approved these changes
Feb 11, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This Pull Request addresses POSIX compatibility and thread-safety issues when building with MinGW-w64.
Changes
Fixes #3038 and #3037