Skip to content

feat: incorporate integration tests into check wf #2078

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
metju-ac merged 1 commit into from
Mar 26, 2026
Merged

feat: incorporate integration tests into check wf #2078

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
24 changes: 9 additions & 15 deletions .github/workflows/lcm-pipeline.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -56,12 +56,7 @@ jobs:
id: gen-image-tag
run: |
hash=$(date +'%Y%m%d%H%M').${GITHUB_SHA::8}
if [[ "${{ inputs.deploy }}" == "true" ]]; then
prefix=""
else
prefix="dev-"
fi
echo "image_tag=${prefix}${hash}" >> $GITHUB_OUTPUT
echo "image_tag=${hash}" >> $GITHUB_OUTPUT
- name: Read service version
id: read-version
run: |
Expand Down Expand Up @@ -132,14 +127,14 @@ jobs:
- name: Build docker image
uses: ./.github/actions/container-build-push
with:
ecr-repos: ${{ inputs.deploy && format('staging/{0}', matrix.component) || format('gdc-testing/{0}', matrix.component) }}
aws-creds-vault-role: ${{ inputs.deploy && 'ecr-ii-push' || 'ecr-push-testing' }}
aws-creds-vault-path: "secret/data/v3/int/ecr/infra1-user-ecr-rw${{ !inputs.deploy && '-testing' || '' }}"
ecr-repos: staging/${{ matrix.component }}
aws-creds-vault-role: ecr-push
aws-creds-vault-path: "secret/data/v3/int/ecr/infra1-user-ecr-rw"
build-tags: |
latest
${{ needs.prepare-build.outputs.image_tag }}
${{ needs.prepare-build.outputs.service_version }}
${{ needs.prepare-build.outputs.service_major_version }}
${{ inputs.deploy && 'latest' || '' }}
${{ inputs.deploy && needs.prepare-build.outputs.service_version || '' }}
${{ inputs.deploy && needs.prepare-build.outputs.service_major_version || '' }}
build-context: ${{ steps.load-config.outputs.CONTAINER_CONTEXT }}
container-file: ${{ steps.get-image-config.outputs.CONTAINER_FILE }}
vault-url: '${{ secrets.VAULT_ADDRESS }}'
Expand Down Expand Up @@ -247,12 +242,11 @@ jobs:
pipeline_identifier: ${{ needs.prepare-build.outputs.pipeline_identifier }}

lcm-integration-e2e:
needs: [ prepare-build, build-helmreleases, wait-for-deployment ]
needs: [ prepare-build, register-bricks-staging, build-helmreleases, wait-for-deployment ]
if: |
!cancelled() &&
!contains(needs.*.result, 'failure') &&
needs.build-helmreleases.result == 'success' &&
inputs.deploy
needs.register-bricks-staging.result == 'success'
uses: ./.github/workflows/lcm-integration-e2e.yaml
secrets: inherit
permissions:
Expand Down
Loading