feat: make single-dim ExecTable handling optional#957
Merged
Tjev merged 1 commit intogooddata:masterfrom Jan 29, 2025
Merged
Conversation
When used for internal tabular exports the handling of single-dimensional cases (just metrics or just attributes) seems to cause some breakage when fetching execution data. risk: low JIRA: CQ-886
hkad98
approved these changes
Jan 29, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When used for internal tabular exports the handling of single-dimensional cases (just metrics or just attributes) seems to cause some breakage when fetching execution data.
The new optional parameter
always_two_dimensionalwill be removed once the tabular export visObj->ExecDef conversions are not done through pysdk (should be pretty soon...).risk: low
JIRA: CQ-886