feat(gooddata-sdk): [AUTO] add exclude_user_settings parameter to workspace settings methods#1332
Open
yenkins-admin wants to merge 1 commit intomasterfrom
Open
Conversation
…kspace settings methods Added optional 'exclude_user_settings' parameter (bool, default False) to: - CatalogWorkspaceService.resolve_all_workspace_settings - CatalogWorkspaceService.resolve_workspace_settings This allows SDK users to exclude user-level settings from resolution, matching the new functionality available in the underlying API client. Co-Authored-By: Claude Sonnet 4.5 <noreply@anthropic.com>
yenkins-admin
requested review from
hkad98,
jaceksan,
lupko and
pcerny
as code owners
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Added optional exclude_user_settings parameter to SDK wrapper methods for resolving workspace settings.
Problem ID: P008
Workflow: https://github.com/gooddata/gdc-nas/actions/runs/22096000751
Changes in gdc-nas
Commit 8ce1041a4836c36dd86607c60b0f72d3066e5bd9:
excludeUserSettingsquery parameter (boolean, default false) to all four settings resolution endpointsSDK Implementation
Added optional
exclude_user_settingsparameter (bool, default False) to SDK wrapper methods in CatalogWorkspaceService:resolve_all_workspace_settingsresolve_workspace_settingsThis parameter is passed through to the underlying API client methods, allowing SDK users to exclude user-level settings from resolution.
Files Modified
packages/gooddata-sdk/src/gooddata_sdk/catalog/workspace/service.pyJIRA: TBD (Jira sandbox under maintenance)
Risk: Low