feat(gooddata-sdk): [AUTO] add excludeUserSettings parameter to workspace settings resolution methods#1331
Open
yenkins-admin wants to merge 1 commit intomasterfrom
Open
Conversation
…pace settings resolution methods Added exclude_user_settings parameter (default: False) to resolve_all_workspace_settings() and resolve_workspace_settings() methods in CatalogWorkspaceService to enable SDK users to exclude user-level settings from resolution, matching the API client capability. Co-Authored-By: Claude Sonnet 4.5 <noreply@anthropic.com>
yenkins-admin
requested review from
hkad98,
jaceksan,
lupko and
pcerny
as code owners
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Added exclude_user_settings parameter to workspace settings resolution SDK methods to support excluding user-level settings from resolution.
Problem: P016
Workflow: https://github.com/gooddata/gdc-nas/actions/runs/22094366952
Changes in gdc-nas
Added excludeUserSettings query parameter to all 4 settings resolution endpoints in metadata-api. This boolean parameter (default: false) allows excluding user-level settings from resolution.
Commits:
SDK Implementation
Added exclude_user_settings parameter (default: False) to the following methods in CatalogWorkspaceService:
resolve_all_workspace_settings()- now accepts exclude_user_settings and passes it to workspace_resolve_all_settings()resolve_workspace_settings()- now accepts exclude_user_settings and passes it to workspace_resolve_settings()This enables SDK users to exclude user-level settings from resolution when the parameter is set to True.
Files Modified:
JIRA: TBD (Jira sandbox currently in maintenance)
Risk: Low