feat(catalog): add metric_type property to CatalogMetric#1263
Closed
tychtjan wants to merge 1 commit intogooddata:masterfrom
Closed
feat(catalog): add metric_type property to CatalogMetric#1263tychtjan wants to merge 1 commit intogooddata:masterfrom
tychtjan wants to merge 1 commit intogooddata:masterfrom
Conversation
Expose the metric type classification (UNSPECIFIED, CURRENCY) through the CatalogMetric.metric_type property. This allows SDK users to access the semantic categorization of metrics, particularly useful for currency-typed metrics. risk: low jira: DX-306
tychtjan
requested review from
hkad98,
jaceksan,
lupko and
pcerny
as code owners
Author
|
Testing of Claude automation - Dont pull please :) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Add
metric_typeproperty toCatalogMetricclass to expose the metric type classification (e.g., CURRENCY) from the API.Changes
metric_typeproperty toCatalogMetricclass inmetric.pyTesting
ruff,ruff-format)Risk Assessment
Related
Checklist