feat: add exections_cancellable to sdk.create and export Execution#1024
Merged
fiedlr merged 1 commit intogooddata:masterfrom Apr 17, 2025
Merged
feat: add exections_cancellable to sdk.create and export Execution#1024fiedlr merged 1 commit intogooddata:masterfrom
fiedlr merged 1 commit intogooddata:masterfrom
Conversation
fiedlr
force-pushed
the
afi-sdk-fix
branch
3 times, most recently
from
f077b41 to
4619eb3
Compare
|
Codecov ReportAll modified and coverable lines are covered by tests ✅
❗ Your organization needs to install the Codecov GitHub app to enable full functionality. Additional details and impacted files@@ Coverage Diff @@
## master #1024 +/- ##
==========================================
- Coverage 84.37% 83.35% -1.03%
==========================================
Files 141 154 +13
Lines 9603 10423 +820
==========================================
+ Hits 8103 8688 +585
- Misses 1500 1735 +235 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
fiedlr
force-pushed
the
afi-sdk-fix
branch
3 times, most recently
from
57b3095 to
f322ff6
Compare
hkad98
reviewed
Apr 17, 2025
- Execution() instances are needed for the new cancelation method risk: high
fiedlr
changed the title
hkad98
approved these changes
Apr 17, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
executions_cancellabletoGoodDataSdk.createrisk: high