Value type refactoring 2#3605
Open
vigoo wants to merge 11 commits into
Open
Conversation
✅ Deploy Preview for golemcloud canceled.
|
This comment has been minimized.
This comment has been minimized.
mschuwalow
reviewed
Jun 5, 2026
| // before dispatching to the local/secret resolver so a | ||
| // mismatch never opens a durable function (secret path) nor | ||
| // touches local state. | ||
| let declaration_value_type = declaration |
Contributor
There was a problem hiding this comment.
The reason to have expected and declared type was the following:
- declared: the type of the secret in the component at that specific point of replay (not changed after automatic updates due to this being driven by the oplog index)
- expected: the type of the secret requested by the agent at runtime. This does change after automatic updates as the wasm trying to read the secret has changed.
So after an automatic update expected might be != declared. We can handle certain cases like new optional secrets (which is still being done), but other's as well. I didn't get around to ever doing that, but the idea behind that code shape was to do this on the fly transformation of data in resolve_local_config / resolve_secret_config
mschuwalow
approved these changes
Jun 5, 2026
Contributor
mschuwalow
left a comment
mschuwalow
left a comment
There was a problem hiding this comment.
Only had a rough look, especially for the cli parts.
But the parts I checked look good to me
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Resolves #3396
This PR migrates some internal places to the new schema but leaves WIT, gRPC and REST interfaces as they were. For this reason, it temporarily introduces conversions in many places, which are going to be eliminated in the follow-up steps.
AgentErrorpayload