feat: add generic payload decoding helpers - #13
Merged
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. 📢 Thoughts on this report? Let us know! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
Add
Job.PayloadAs[T]andMessage.PayloadAs[T]for typed JSON payload decoding. ExistingBindmethods remain unchanged, with tests covering behavior and error parity plus generated examples for both payload owners.Raise all 12 Queue modules, workspace metadata, documentation, release inventory, and minimum-version CI coverage to Go 1.27. The sibling-module
replacedirectives used by repository-wide tests remain in place.Before and after
Both concrete payload owners can now return the decoded type instead of asking callers to prepare mutable state.
Message.PayloadAs
Before:
After:
Job.PayloadAs
Before:
After:
Existing
Bindmethods remain the right choice when a caller intentionally wants to populate an existing value.Why
Queue's pointer-based decoding was another visible scar from the old generic-method limitation. Go 1.27 lets payload ownership read naturally: ask the job or message for the type you need, receive it directly, and handle the same errors as before.
Performance
The result-returning methods add no allocation cost. Job
BindandPayloadAsboth use 24 B and 2 allocations; MessageBindandPayloadAsboth use 8 B and 1 allocation. Repeated single-core runs keep both call forms in the same timing range.