Skip to content

Backport #1918: Fix multi-file dependency in generate_doc_source for 4.5 branch. - #2049

Merged
dsnopek merged 2 commits into
godotengine:4.5from
SpeechlessMatt:multiple-XML-doc-sources
Aug 25, 2026
Merged

Backport #1918: Fix multi-file dependency in generate_doc_source for 4.5 branch.#2049
dsnopek merged 2 commits into
godotengine:4.5from
SpeechlessMatt:multiple-XML-doc-sources

Conversation

@SpeechlessMatt

Copy link
Copy Markdown

This is a backport of #1918 for the 4.5 branch.

It fixes an issue where multiple XML documentation source files were not properly handled as dependencies in generate_doc_source (due to quotes around ${SOURCES} in DEPENDS), causing multi-file tracking and deletion detection to fail.

Linked PR: #1918

@SpeechlessMatt
SpeechlessMatt requested a review from a team as a code owner August 25, 2026 10:06
@dsnopek dsnopek added the bug This has been identified as a bug label Aug 25, 2026
@dsnopek dsnopek added this to the 4.5 milestone Aug 25, 2026

@dsnopek dsnopek left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@dsnopek
dsnopek merged commit 27d9dd2 into godotengine:4.5 Aug 25, 2026
10 checks passed
@dsnopek dsnopek added the cmake label Aug 25, 2026
@SpeechlessMatt
SpeechlessMatt deleted the multiple-XML-doc-sources branch August 26, 2026 04:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug This has been identified as a bug cmake

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants