Sync math structs by adding constexpr constructors/operators - #2047
Merged
Conversation
Contributor
Author
|
While syncing the files I removed the hash() function from classes implementing them. As including hashfuncs.h then caused errors. (from cyclic inclusion). Was/Is there a better way to go about it? |
Ivorforce
approved these changes
Aug 25, 2026
Ivorforce
left a comment
Ivorforce
left a comment
Member
There was a problem hiding this comment.
Looks great! I didn't see any problems.
Regarding the hash() drop: That's fine for now. hashfuncs.h should be synced too, but that can be done as a separate pr.
This pr has some compat breaks so it would be good to have before v10.
Ivorforce
added
bug
dsnopek
reviewed
Aug 25, 2026
dsnopek
left a comment
dsnopek
left a comment
Collaborator
There was a problem hiding this comment.
Thanks! Only a couple small notes below
Also, please squash your changes down to a single commit:
marcozee03
force-pushed
the
sync-godot-math-structs
branch
from
August 25, 2026 22:48
69926f2 to
f8f7d70
Compare
marcozee03
force-pushed
the
sync-godot-math-structs
branch
from
August 25, 2026 22:58
f8f7d70 to
93bcf21
Compare
Contributor
Author
|
Thanks for the feedback. I have implemented it and squashed the commit as you've suggested. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
closes #2046
Synced the math types like Vector* and Transform* with upstream