feat(environments): read DevX Core URL from config (DEVX-793) - #190
Open
smukherjee-godaddy wants to merge 1 commit into
Open
feat(environments): read DevX Core URL from config (DEVX-793)#190smukherjee-godaddy wants to merge 1 commit into
smukherjee-godaddy wants to merge 1 commit into
Conversation
| derive_account_url(sources.env_name().unwrap_or_default()) | ||
| } | ||
|
|
||
| fn default_devx_core_url(sources: &SourceChain<'_>) -> String { |
Collaborator
There was a problem hiding this comment.
It'd be simpler if you added the config value to BUILTIN_ENVS and extended BaseEnvConfig; then you don't need a separate environment-to-values lookup table or this function. The default function is mainly for if you needed to compute a default; for pre-populating built-in environments, we already have a mechanism for that.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
devx_core_urlfrom each activeenvironments.tomlentry<ENV>_DEVX_CORE_URLandDEVX_CORE_URLas higher-precedence runtime overridesprodandote, and cover file configuration, precedence, and invalid URLsExample
Validation
cargo checkcargo clippy -- -D warningscargo test(552 passed)cargo fmt --checkhttps://godaddy-corp.atlassian.net/browse/DEVX-793