feat(cli): opt into cli-engine pagination for domain/dns list and api search [DEVEX-972] - #189
Open
jpage-godaddy wants to merge 1 commit into
Open
feat(cli): opt into cli-engine pagination for domain/dns list and api search [DEVEX-972]#189jpage-godaddy wants to merge 1 commit into
jpage-godaddy wants to merge 1 commit into
Conversation
…pi search [DEVEX-972] Adds `--limit`/`--offset` pagination (capped max_limit, no forced default) to `domain list`, `dns list`, `application list`, and `api search` via cli-engine's now-published `CommandSpec::with_pagination`. Bumps httpmock 0.7 -> 0.8 across the workspace to drop the last lingering hyper 0.14 dependency, which was forcing socket2 into two incompatible version buckets in the lockfile.
qcai-godaddy
approved these changes
Aug 7, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
domain list,dns list,application list, andapi searchinto cli-engine's now-publishedCommandSpec::with_pagination(--limit/--offset, cappedmax_limit, no forced default so unflagged invocations keep returning everything).cli-engine0.6->0.8(the version that actually shippedwith_pagination, per DEVEX-972) and drops the temporary local-path[patch.crates-io]this branch was using to prove the feature out before it was released.httpmock0.7->0.8(both the top-level anddomains-clientdev-dependency) to drop the workspace's lasthyper0.14 pull, which was forcingsocket2into two incompatible version buckets in the lockfile. Fixes the resulting breaking API changes in test code (.matches->.is_true,.hits_async/.assert_hits_async->.calls_async/.assert_calls_async, privatebody/headersfields -> accessor methods).Test plan
cargo checkcargo clippy -- -D warningscargo test(554 passed)cargo fmt --check