fix(env): add app config summary to env info [DEVEX-715] - #185
Merged
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
This PR updates the env info command to support inspecting a specific environment without changing persisted state, and enriches the JSON output with local app manifest (godaddy*.toml) context for tooling.
Changes:
- Extend
EnvInfooutput to includeconfigFileandconfigSummaryderived from the local manifest when present/valid. - Add an environment selector argument to
gddy env info(defaulting to the active environment). - Add tests covering the new
env infooutput fields and argument behavior, plus unit tests for manifest summarization.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Contributor
There was a problem hiding this comment.
Pull request overview
Copilot reviewed 1 out of 1 changed files in this pull request and generated no new comments.
Suppressed comments (1)
rust/src/env/mod.rs:40
- The doc comment for
config_contextsaysgodaddy[.env].toml, which reads like it refers to a.envfile rather than the intended optional.<env>suffix. This could mislead readers about which manifest file is being summarized.
/// Path to the env's `godaddy[.env].toml` (absolute when possible), plus an
/// optional summary when the file exists and validates. Missing/invalid
/// configs yield `configSummary: null`.
Contributor
There was a problem hiding this comment.
Pull request overview
Copilot reviewed 1 out of 1 changed files in this pull request and generated no new comments.
Suppressed comments (2)
rust/src/env/mod.rs:481
config_summary_for_pathis documented/used to treat missing and invalid manifests as a soft failure (configSummary: null), but the unit tests only cover the missing-file case. Adding a test that exercises the invalid/parse-failure path would lock in the behavior.
#[test]
fn config_summary_for_path_returns_none_when_missing() {
let dir = tempfile::tempdir().expect("tempdir");
let path = dir.path().join("godaddy.toml");
assert!(super::config_summary_for_path(&path).is_none());
}
rust/src/env/mod.rs:35
- The PR description says both
configFileandconfigSummaryshould benullwhen the local manifest is missing/invalid, butEnvInfodefinesconfigFileas a required string and the implementation always returns a path even when the summary isnull. Please align the description and implementation (either makeconfigFilenullable/conditional, or update the description/help text to reflect thatconfigFileis always populated with the expected manifest path).
This issue also appears on line 476 of the same file.
"env": "string";
"apiUrl": "string";
"graphqlUrl": "string";
"configFile": "string";
"configSummary": "object|null";
jpage-godaddy
approved these changes
Aug 4, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
env infofor the active environment with always-presentconfigFile(expectedgodaddy.toml/godaddy.<env>.tomlpath) andconfigSummary(objectwhen the manifest validates, otherwisenull)env get/env listshapes unchanged; unknown--envhard-fail and oldGODADDY_*overrides already fixeddisplay(color/label) and optionalenv info [environment]: display is unused noise, and a positional inspect switch duplicates/confuses global--envwhileenv *already reports persisted active (~/.gdenv)Test plan
cargo build/cargo fmt --check/cargo clippy -- -D warnings/cargo testgddy env info --output jsonreturnsenv,apiUrl,graphqlUrl,configFile,configSummarygddy env info oteis rejected (no positional)godaddy.tomlin cwd,configSummaryis populated; without it,configFileis still set andconfigSummaryisnull