Skip to content

Move render_js() call to enqueue scripts callback #848

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
agibson-godaddy merged 2 commits into from
Jun 23, 2026
Merged

Move render_js() call to enqueue scripts callback #848

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
5509eea
Move render_js() call to enqueue scripts callback
agibson-godaddy Jun 23, 2026
d10523a
Switch to inline jQuery
agibson-godaddy Jun 23, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions woocommerce/changelog.txt
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,7 @@
*** SkyVerge WooCommerce Plugin Framework Changelog ***

2026.nn.nn - version 6.2.3
* Fix - Address "wp_script_is was called incorrectly" errors when instantiating the `SV_WP_Job_Batch_Handler` class

2026.06.15 - version 6.2.2
* Fix - Failed transaction attempt causes future attempts to fail when using Block checkout
Expand Down
6 changes: 3 additions & 3 deletions woocommerce/utilities/class-sv-wp-job-batch-handler.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -71,8 +71,6 @@ public function __construct( $job_handler, SV_WC_Plugin $plugin ) {
$this->plugin = $plugin;

$this->add_hooks();

$this->render_js();
}


Expand Down Expand Up @@ -110,6 +108,8 @@ protected function getScriptHandle() : string
public function enqueue_scripts() {

wp_enqueue_script( $this->getScriptHandle(), $this->get_plugin()->get_framework_assets_url() . '/js/admin/sv-wp-admin-job-batch-handler.min.js', [ 'jquery' ], $this->get_plugin()->get_assets_version() );

$this->render_js();
}


Expand All @@ -136,7 +136,7 @@ protected function render_js() {
json_encode( $args )
);

ScriptHelper::addInlineScript($this->getScriptHandle(), $script);
ScriptHelper::addInlinejQuery($this->getScriptHandle(), $script);
}


Expand Down