Skip to content

Feat/cleanup before v3 #47

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
fredbi merged 16 commits into from
Jan 26, 2026
Merged

Feat/cleanup before v3 #47

fredbi merged 16 commits into from
Jan 26, 2026
+1,221 −634

Conversation

@fredbi
Copy link
Member

@fredbi fredbi commented Jan 26, 2026

Change type

Please select: 🆕 New feature or enhancement|🔧 Bug fix'|📃 Documentation update

Short description

Fixes

Full description

Checklist

  • I have signed all my commits with my name and email (see DCO. This does not require a PGP-signed commit
  • I have rebased and squashed my work, so only one commit remains
  • I have added tests to cover my changes.
  • I have properly enriched go doc comments in code.
  • I have properly documented any breaking change.

fredbi added 12 commits January 26, 2026 12:51
@fredbi
refact: moved assert/enable to enable/stubs (usage is symmetric)
f442a0f 
Signed-off-by: Frederic BIDON <fredbi@yahoo.com>
@fredbi
refact(condition): reduced contrated complexity of the polling component
bb6b75b 
Signed-off-by: Frederic BIDON <fredbi@yahoo.com>
@fredbi
refact(string): rewritten hack prioritized logical expressions with c…
0c4f236 
…learer sequence

Signed-off-by: Frederic BIDON <fredbi@yahoo.com>
@fredbi
refact(diff): removed the need for a global spew config.
39201bf 
Simplified the switch: the new spew is able to figure out types by
itself (and more accurately).

Added diff test specifically for when times need to be rendered.

Signed-off-by: Frederic BIDON <fredbi@yahoo.com>
@fredbi
test(equal): removed redundant tests covered by unified test cases
43574c8 
Signed-off-by: Frederic BIDON <fredbi@yahoo.com>
@fredbi
refact: removed New() from internal/assertions (it is generated anyways)
2bee8b1 
Signed-off-by: Frederic BIDON <fredbi@yahoo.com>
@fredbi
chore: fixed missing license headers
659f898 
Signed-off-by: Frederic BIDON <fredbi@yahoo.com>
@fredbi
test: added tests to cover the stubs/enable features
209d4c1 
Signed-off-by: Frederic BIDON <fredbi@yahoo.com>
@fredbi
ci: added build tag to extend test coverage on spew
961f2aa 
Signed-off-by: Frederic BIDON <fredbi@yahoo.com>
@fredbi
fix(diff): check edge case for nil interface (did panic)
b630967 
Signed-off-by: Frederic BIDON <fredbi@yahoo.com>
@fredbi
chore: addressed/reformulated a few proposals for enhancements in com…
cbd4c16 
…ments (tests)

refact(error): example error is now a type and its value a constant

Signed-off-by: Frederic BIDON <fredbi@yahoo.com>
@fredbi
tests: reverted change to example test error (tests assert exact mess…
5cf74a0 
…age)

Signed-off-by: Frederic BIDON <fredbi@yahoo.com>
@codecov
Copy link

codecov bot commented Jan 26, 2026 •
edited
Loading

Codecov Report

❌ Patch coverage is 98.55072% with 2 lines in your changes missing coverage. Please review.
✅ Project coverage is 96.66%. Comparing base (5d65adf) to head (3bbd617).
⚠️ Report is 17 commits behind head on master.
✅ All tests successful. No failed tests found.

Files with missing lines Patch % Lines
internal/assertions/condition.go 98.26% 2 Missing ⚠️
Additional details and impacted files 
@@            Coverage Diff             @@
##           master      #47      +/-   ##
==========================================
+ Coverage   88.87%   96.66%   +7.79%     
==========================================
  Files          73       53      -20     
  Lines       10005     8227    -1778     
==========================================
- Hits         8892     7953     -939     
+ Misses        945      182     -763     
+ Partials      168       92      -76

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

fredbi added 4 commits January 26, 2026 22:13
@fredbi
test: refactored string test (removed redundant test cases)
015d3e3 
Signed-off-by: Frederic BIDON <fredbi@yahoo.com>
@fredbi
test: covered internal safeguard against nil interface values
e70cc55 
Signed-off-by: Frederic BIDON <fredbi@yahoo.com>
@fredbi
test: refact enable/yaml tests
a8006ab 
Signed-off-by: Frederic BIDON <fredbi@yahoo.com>
@fredbi
ci: updated shared workflows to v0.2.5
3bbd617 
Signed-off-by: Frederic BIDON <fredbi@yahoo.com>
@fredbi fredbi merged commit f6b39fc into go-openapi:master Jan 26, 2026
28 of 35 checks passed
@fredbi fredbi deleted the feat/cleanup-before-v3 branch January 26, 2026 22:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

1 participant

@fredbi