fix(post-review): simplify to single REMOTE, template cleanup, CLA timing fix#3
Merged
Merged
Conversation
…ics, template cleanup - Move mnemonics from Dockerfile to Makefile; inject via docker run -e - Add REMOTES parsing explanation in template Makefile, samourai-crew Makefile, and README - Replace opinionated list-funding-* in template with exit 1 stubs - Remove ADDR_1/FUND_AMOUNT_* from template - Document that all env vars (addresses, mnemonics) must be defined in the Makefile - Update README steps 3/4/5 to reflect new account injection pattern
…mismatch CLA transactions were still in the mempool when e2e_nonce_replay sent its first tx, causing the node to reject it with signature verification failed due to a stale sequence number on-chain.
Simplifies the contributor API from a comma-separated RPC list to a single REMOTE variable. Stress tests now target one node with N wallets in parallel instead of mapping one wallet to one RPC each.
louis14448
changed the title
aeddi
approved these changes
May 27, 2026
Contributor
aeddi
left a comment
aeddi
left a comment
There was a problem hiding this comment.
LGTM overall, please just address the last comments, then feel free to merge when done 👍
…oosen contributor guidance
louis14448
force-pushed
the
fix/post-review-corrections
branch
from
b899a94 to
27bd23a
Compare
aeddi
approved these changes
May 28, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Addresses the points left open by aeddi after merging #1, plus a follow-up simplification agreed with Rémi.
Changes
Single source of truth for account config (
tests/samourai-crew/)docker run -eREMOTESreplaced by singleREMOTEREMOTEin parallel (wallet detection from keystore)CLA timing fix
sleep 2→sleep 10after CLA signing to let transactions commit before tests startsignature verification failedone2e_nonce_replayTemplate cleanup (
_template/Makefile)list-funding-*replaced byexit 1stubs (forces contributors to implement)README updated
-eflags)REMOTEusage documented with shell example