Solution for assignment #3 - Shell Sort#31
Open
diegopetrucci wants to merge 2 commits intogmertk:masterfrom
Open
Solution for assignment #3 - Shell Sort#31diegopetrucci wants to merge 2 commits intogmertk:masterfrom
diegopetrucci wants to merge 2 commits intogmertk:masterfrom
Conversation
This code doesn’t actually work and I can’t understand why. Anyone can help?
Author
|
The title is incorrect: this is the solution for shell sort. |
There was a problem hiding this comment.
You never generate the last gap value, which must always be equal to 1, because the last step of shell sort is an insertion sort. Try to change from
return number > 1 ? number : nil
to
return number >= 1 ? number : nil
or
return number > 0 ? number : nil
Thanks @matteomatassoni
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This code doesn’t actually work and I can’t understand why. Anyone can
help?