Conversation
ginnymin
commented
Jan 9, 2026
| mac: | ||
| macos: | ||
| xcode: 14.0.0 | ||
| xcode: 14.3.1 |
Author
There was a problem hiding this comment.
integration-test-templates-mac was erroring with a "resource not available for this class" type of error. Used this guide to select a version that is available.
| for i in $(eval echo \""$GLUE_PARAM_TARGET"\" | sed "s/,/ /g"); do | ||
| echo "Sending to Glue Target: $i" | ||
| GLUE_MSG_BODY=$(echo "$GLUE_MSG_BODY" | jq --arg target "$i" '.target = $target') | ||
| SendToTarget() { |
Author
There was a problem hiding this comment.
SendToTarget wraps the previous logic that was being executed in the for loop; PostToGlue now has a conditional check for the threadBy or threadSubject to determine whether or not to call SendToTarget in a loop or not.
lucaspeterson22
approved these changes
Jan 10, 2026
| `thread_subject` parameter determines the subject of the thread. | ||
| `thread_by` parameter holds a thread identifier in case there are multiple notifications in the pipeline. | ||
|
|
||
| Note: target must be a group(s) if a thread is specified. |
There was a problem hiding this comment.
Suggested change
| Note: target must be a group(s) if a thread is specified. | |
| Note: target must be a group(s) if a `thread_subject` is specified. |
michaelknowles
approved these changes
Jan 10, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
API-1477
When using
glue/notifyfor posting to a thread with multiple targets, we were getting duplicate messages being posted in the thread due to the notify script looping through the targets and callingcurlto the webhook for each target. This adds a check to only do the loop when thread subject and threadBy are not provided, otherwise making a single call to the webhook for threads.