Add smoke test for Custom Metadata SDK grouping#105
Merged
Conversation
Asserts that the five Custom Metadata operations exposed by the overlay end up under x-speakeasy-group: indexing.customMetadata with the expected x-speakeasy-name-override values, so a future overlay reorder or upstream schema rename surfaces as a test failure rather than silent SDK drift. This test was originally part of #101 but removed before merge because the regen pipeline hadn't yet committed a fresh overlayed_specs/glean-merged-spec.yaml. With that file now in place on main, the assertion is meaningful again. Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
…ition The overlay introduces a Custom Metadata-specific PropertyDefinition schema (exposing only name, propertyType, and skipIndexing) and re-points CustomMetadataSchema.metadataKeys.items at it. This test locks both halves down so that neither an upstream rename of CustomMetadataSchema/PropertyDefinition nor a future overlay reorder can silently revert the narrowing. Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
steve-calvert-glean
approved these changes
May 14, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Adds an assertion in
tests/post_transform_smoke.test.jsthat the five Custom Metadata operations land underx-speakeasy-group: indexing.customMetadatawith the expectedx-speakeasy-name-overridevalues (upsert,delete,getSchema,upsertSchema,deleteSchema).This was originally part of #101 but removed before merge because the regen pipeline hadn't yet committed a fresh
overlayed_specs/glean-merged-spec.yaml. With that file now onmain, the assertion is meaningful and protects against future overlay reorders or upstream schema renames silently breaking SDK grouping.Test plan
pnpm test— all 64 tests pass locally.🤖 Generated with Claude Code