Handled empty string passed for FORWARD_PROXY variables

[bhuvan-teja-glean]

Description:

Context:

Test plan:
Ran the glean-proxy server with the following environment variable
bazel run //src/main/java/com/glean/proxy:ProxyMain 8080
Environment variables

export CLOUD_PLATFORM=AWS
export AWS_FILTERS=
export GOOGLE_FILTERS=
export CROSS_PLATFORM_FILTERS=
export DEBUG_FILTERS=
export FORWARD_PROXY_HOST=localhost
export FORWARD_PROXY_PORT=8888
export FORWARD_PROXY_DATA_SOURCE_HOSTS=www.google.com,www.glean.com
export FORWARD_PROXY_USERNAME=
export FORWARD_PROXY_PASSWORD=

For the forward proxy we just used the glean-proxy to run as forward proxy with a different port
bazel run //src/main/java/com/glean/proxy:ProxyMain 8888
Environment variables

export CLOUD_PLATFORM=AWS
export AWS_FILTERS=
export GOOGLE_FILTERS=
export CROSS_PLATFORM_FILTERS=
export DEBUG_FILTERS=

Made the following requests

1. curl --proxy localhost:8080 https://www.example.com
2. curl --proxy localhost:8080 https://www.google.com

Screenshot of glean-proxy at 8080 logs

Screenshot of forward-proxy at 8888 logs

As you see only www.google.com went through the forward proxy and www.example.com doesn't have any log in the forward proxy as it is a direct connection

---

Change Type

• Flag-gated development/Internal fix
• Bug Fix/Enhancement
• Security or Permissions related change
• Feature launch

Platform (Choose one if applicable)

• AWS only change
• GCP only change