FIX: ignore module "studio_customization" that is only present in the database - #1
Closed
glasl wants to merge 1 commit into
Closed
FIX: ignore module "studio_customization" that is only present in the database#1glasl wants to merge 1 commit into
glasl wants to merge 1 commit into
Conversation
… database, The Odoo Enterprise "Studio" module creates a new module "studio_customization" in the database. Since we're only comparing checksums of modules stored in the file system, ignoring this fixes the update mechanism on Odoo Enterprise installations.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The Odoo Enterprise "Studio" module creates a new module "studio_customization" in the database. Since we're only comparing checksums of modules stored in the file system, ignoring this fixes the update mechanism on Odoo Enterprise installations.
Ignoring this single edge case in the query seems more straight forward to me, than implementing _module_exists_on_disk() + tests and having to call it for every module in a for-loop.
Feel free to point out other cases that might be missed by this patch.
This patch was tested and is running in our Odoo Enterprise with Studio.