Use typed data APIs

[nobu]

Untyped data APIs are deprecated.

[gjtorikian]

Thank you for the PR, but, the version of the code you are targeting is years old. Where is it being used?

[nobu]

Here: https://github.com/ruby/ruby-bench/blob/main/benchmarks/lobsters/Gemfile#L48

[gjtorikian]

Please help me understand. What is ruby-bench? What is lobsters?

The v1.0 Rust gem doesn't compile on Ruby master

That comment was from a year ago. Has anyone tried updating since then?

[kivikakk]

It looks like an older version of the lobste.rs source code, used to benchmark YJIT. Lobsters does use Commonmarker 2.x now, since July this year. Maybe the benchmark could be updated rather than relying on years-old code.

[nobu]

Thank you, we'll update or remove the old gem.

[kivikakk]

Thank you!

[composerinteralia]

FWIW we're still using the c-api-stable branch at GitHub, and it'd be handy to have this change, but I also understand if you no longer want to support this old branch.

If you are still open to supporting it, I could also open a PR to relax the Ruby version constraint on that branch along the same lines as 5655513

Thank you!

[gjtorikian]

What's the apprehension to upgrading off of a four-year-old branch?

[composerinteralia]

Mainly staffing (failing tests and nobody to fix them) but also general avoidance of rust extensions for various reasons.

Neither of those are your problem at all, so I fully understand whatever maintenance choice you make.

[gjtorikian]

Well, mostly, I'm just trying to understand the apprehension, as I said. If I need to keep maintaining a branch I'm not interested in maintaining, I'd like a good reason.

Recently, someone made the case that a change needed to be made to fix an issue with GitHub Pages, so I fixed it. But in this thread, the reasons have been "there's a random outdated benchmark somewhere" and "an avoidance of rust extensions," neither of which are actual explanations for me to understand the problem of why this change needs to be made, what problems it solves, what problems not fixing it causes, etc.