This repository was archived by the owner on Nov 30, 2021. It is now read-only.
$persistent_messages parameter wasn't passed further to queue declaration#112
Open
lexabug wants to merge 4 commits intogjedeer:masterfrom
Open
$persistent_messages parameter wasn't passed further to queue declaration#112lexabug wants to merge 4 commits intogjedeer:masterfrom
lexabug wants to merge 4 commits intogjedeer:masterfrom
Conversation
$persistent_messages parameter wasn't passed further to queue declaration. $connector arg defaults to null since it better fits "not specified" value.
… code that explicitly passes false.
…ting key "celery" - queue "celery"
jdufresne
reviewed
Jul 20, 2018
| public function __construct($host, $login, $password, $vhost, $exchange='celery', $binding='celery', $port=5672, $connector=null, $persistent_messages=false, $result_expire=0, $ssl_options=[]) | ||
| { | ||
| $broker_connection = [ | ||
| $backend_connection = $broker_connection = [ |
Collaborator
There was a problem hiding this comment.
What is the purpose of defining the same array twice?
| 'binding' => $binding, | ||
| 'port' => $port, | ||
| 'connector' => $connector, | ||
| 'connector' => $connector !== false ? $connector : null, |
Collaborator
There was a problem hiding this comment.
false is no longer the default, so you can drop this ternary.
Collaborator
|
@lexabug Thanks! Can you rebase this on the latest master. Would it be possible to add a test for Can you also update the example in the README? The connector argument should now be |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixed doc block of the Celery constructor.
$persistent_messages parameter wasn't passed further to queue declaration.
$connector arg defaults to null since it better fits "not specified" value.