Switch to controller-runtime SSA for resource management#318
Draft
Switch to controller-runtime SSA for resource management#318
Conversation
Contributor
Author
|
@bigkevmcd 👋 This repository doesn't have Copilot instructions. With Copilot instructions, I can understand the repository better, work faster and produce higher quality PRs. I can generate a .github/copilot-instructions.md file for you automatically. Click here to open a pre-filled issue and assign it to me. I'll write the instructions, and then tag you for review. |
Co-authored-by: bigkevmcd <867746+bigkevmcd@users.noreply.github.com>
Copilot
AI
changed the title
[WIP] Switch to controller-runtime SSA
Switch to controller-runtime SSA for resource management
Aug 14, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR migrates the GitOpsSet controller from traditional Create/Patch operations to Server-Side Apply (SSA) using controller-runtime's built-in SSA support.
Changes Made
The core change is in the
renderAndReconcilefunction where the complex resource management logic has been simplified:Before: Complex logic with separate Create/Update paths
After: Simple, unified server-side apply
Benefits
Additional Changes
copyUnstructuredContenthelper function (no longer needed)apierrorsimportThe implementation follows the official controller-runtime SSA documentation referenced in the issue and represents a significant improvement in reliability and maintainability.
Fixes #115.
💬 Share your feedback on Copilot coding agent for the chance to win a $200 gift card! Click here to start the survey.