Fix safe_outputs failure in resolve-pull-request-review-thread test - #11352
Merged
Conversation
Co-authored-by: pelikhan <4175913+pelikhan@users.noreply.github.com>
Copilot created this pull request from a session on behalf of
pelikhan
August 5, 2026 17:02
View session
pelikhan
approved these changes
Aug 5, 2026
pelikhan
marked this pull request as ready for review
August 5, 2026 17:33
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The
safe_outputsjob of Test Copilot Resolve Pull Request Review Thread failed because theresolve_pull_request_review_threadmutation was handed a non-node-idthread_id— a leaked GitHub REST 422 error payload — producingCould not resolve to a node with the global id.The bad value originates in the
e2e.shfixturecreate_test_pr_with_review_comment: when the review-commentPOSTfails (e.g. 422 before the commit lands in the PR diff), the fixture could still emit apr,comment_id,thread_idtuple with an empty/garbage identifier, which is then passed as theworkflow_dispatchinput consumed by the workflow'ssamples:block.Changes (
e2e.sh)POSTyields a numeric comment id, so the caller's[[ -n ... ]]guards skip the dispatch instead of triggering with a bogus id.thread_idthat isn't shaped like a GraphQL node id (^[A-Za-z0-9_=-]+$), so error payloads / partial responses are never forwarded as a dispatch input.The test remains meaningful when the fixture succeeds; the harness can no longer dispatch the workflow with an invalid thread identifier.