Skip to content

Add explicit permissions to GitHub Actions workflows #107

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
jonrohan merged 4 commits into from
Nov 25, 2025
Merged

Add explicit permissions to GitHub Actions workflows #107

Show file tree
Hide file tree
Changes from 3 commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
cff943f
Initial plan
Copilot Nov 20, 2025
71b4538
Initial analysis complete - ready to add workflow permissions
Copilot Nov 20, 2025
3d24f96
Add explicit permissions to GitHub Actions workflows
Copilot Nov 20, 2025
40ac68a
Rename variables in custom-elements.json
jonrohan Nov 25, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 4 additions & 0 deletions .github/workflows/nodejs.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,10 @@
name: Node CI

on: push

permissions:
contents: read

jobs:
build:
runs-on: ubuntu-latest
Expand Down
3 changes: 3 additions & 0 deletions .github/workflows/publish.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,6 +4,9 @@ on:
release:
types: [created]

permissions:
contents: read

jobs:
publish-npm:
runs-on: ubuntu-latest
Expand Down
8 changes: 4 additions & 4 deletions custom-elements.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -9,16 +9,16 @@
{
"kind": "variable",
"name": "TabContainerChangeEvent",
"default": "_TabContainerChangeEvent"
"default": "class extends Event {\n static"
Copy link
Copy Markdown
Contributor

@francinelucca francinelucca Nov 25, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

what's happening here 👀

},
{
"kind": "variable",
"name": "TabContainerElement",
"default": "_TabContainerElement"
"default": "class extends HTMLElement {\n static"
},
{
"kind": "variable",
"name": "dist_default",
"name": "index_default",
"default": "TabContainerElement"
}
],
Expand All @@ -43,7 +43,7 @@
"kind": "js",
"name": "default",
"declaration": {
"name": "dist_default",
"name": "index_default",
"module": "dist/bundle.js"
}
}
Expand Down
Loading