-
Notifications
You must be signed in to change notification settings - Fork 12
feat: split decorator architecture and add universal entry points #41
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from all commits
Commits
Show all changes
16 commits
Select commit
Hold shift + click to select a range
79648ea
feat: split decorator architecture and add universal entry points
mattcosta7 6d3e5eb
feat: add examples-html package and update docs for universal support
mattcosta7 af41249
Add Universal Storybook cross-link to React storybook sidebar
mattcosta7 5140282
fix: restore portless dep, revert layout.module.css style change
mattcosta7 8254107
Merge branch 'main' into universal-split
mattcosta7 c517954
Merge branch 'main' into universal-split
mattcosta7 0e25515
Merge branch 'main' into universal-split
mattcosta7 0b64f49
respond to some pr comments
mattcosta7 4ae4209
fix auto-discovery duplication
mattcosta7 e4e58ab
Merge branch 'main' into universal-split
mattcosta7 3e82ebb
Update packages/storybook-addon-performance-panel/package.json
mattcosta7 4be2daf
Update packages/examples-html/stories/LayoutThrashing.stories.ts
mattcosta7 311d826
Initial plan
Copilot 557fe8e
Fix useLayoutEffect cleanup for MutationObserver in performance-decor…
Copilot d6c4f43
Merge pull request #52 from github/copilot/sub-pr-41
mattcosta7 c0abaed
Merge branch 'main' into universal-split
mattcosta7 File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,17 @@ | ||
| --- | ||
| "@github-ui/storybook-addon-performance-panel": minor | ||
| --- | ||
|
|
||
| Add framework-agnostic support via new universal entry points and split decorator architecture. | ||
|
|
||
| New entry points: | ||
| - `./universal` — non-React public API (universal decorator + core) | ||
| - `./react` — React-specific API with Profiler support | ||
|
|
||
| New files: | ||
| - `core/preview-core.ts` — shared `PerformanceMonitorCore` class | ||
| - `decorators/universal.ts` — framework-agnostic decorator | ||
| - `decorators/react.tsx` — React.Profiler bridge decorator | ||
| - `preset-universal.ts` / `preview-universal.ts` — Storybook preset for non-React frameworks | ||
|
|
||
| The React decorator stack is now `[withPerformanceMonitor, withReactProfiler]`, where the universal layer handles browser-level metrics and the React layer adds Profiler integration. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.