Skip to content

fix: cap stdin read at 1 MiB to prevent DoS #3857

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
Quratulain-bilal wants to merge 1 commit into
base: main
Choose a base branch
from
Open

fix: cap stdin read at 1 MiB to prevent DoS #3857

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 9 additions & 2 deletions src/specify_cli/commands/event.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -24,8 +24,15 @@ def event_run(
"""Resolve and run an event-driven command script with stdin payload."""
from ..events import resolve_and_run_event_command

# Read payload from stdin if available
payload = sys.stdin.read() if not sys.stdin.isatty() else "{}"
# Read payload from stdin if available (capped at 1 MiB to prevent DoS)
_MAX_PAYLOAD = 1 * 1024 * 1024
if not sys.stdin.isatty():
raw = sys.stdin.read(_MAX_PAYLOAD)
if not sys.stdin.eof:
raise typer.Exit(code=1, message="stdin payload exceeds 1 MiB limit")
payload = raw
else:
payload = "{}"

# Run the event command
project_root = Path.cwd() # The agent runs events from project root
Expand Down