fix: use missing_ok=True in extension cache clear - #3845
Open
Quratulain-bilal wants to merge 1 commit into
Open
Conversation
Replace check-then-act pattern (exists()+unlink()) with unlink(missing_ok=True) to eliminate TOCTOU race condition. Matches the pattern already used for per-URL cache files in the same method.
Contributor
There was a problem hiding this comment.
Pull request overview
Eliminates a TOCTOU race when clearing extension catalog caches.
Changes:
- Replaces existence checks with atomic, idempotent
unlink(missing_ok=True)calls.
Show a summary per file
| File | Description |
|---|---|
src/specify_cli/extensions/__init__.py |
Safely removes cache and metadata files. |
Review details
Tip
Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
- Files reviewed: 1/1 changed files
- Comments generated: 0
- Review effort level: Medium
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Replace check-then-act pattern with
unlink(missing_ok=True)to eliminate TOCTOU race.Changes
extensions/__init__.py: Usemissing_ok=Trueinclear_cache()matching the pattern used for per-URL cache files