fix: escape Rich markup in workflow error output - #3837
Open
Quratulain-bilal wants to merge 1 commit into
Open
Conversation
Escape user-controlled exception text with _escape_markup() to prevent Rich from interpreting square brackets as markup tags, which could corrupt output or raise MarkupError. Matches the pattern used in workflow_resume and all other err.print() calls in this file.
Contributor
There was a problem hiding this comment.
🟡 Not ready to approve
The earlier workflow-loading error handler remains vulnerable to Rich markup interpretation.
Once you've addressed the issues Copilot identified, you can request another Copilot review.
This review doesn't count toward merge requirements. Sign up for the private preview to control whether Copilot approvals count.
Pull request overview
Escapes Rich markup in workflow execution error messages.
Changes:
- Escapes
ValueErrorand generic execution exception text.
File summaries
| File | Description |
|---|---|
src/specify_cli/workflows/_commands.py |
Escapes runtime error output. |
Review details
- Files reviewed: 1/1 changed files
- Comments generated: 1
- Review effort level: Medium
We're testing this review assessment. Please use 👍 or 👎 to tell us if it's correct.
| ) | ||
| except ValueError as exc: | ||
| err.print(f"[red]Error:[/red] {exc}") | ||
| err.print(f"[red]Error:[/red] {_escape_markup(str(exc))}") |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Escape exception text with
_escape_markup()to prevent Rich from interpreting square brackets as markup tags.Changes
_commands.py: Added_escape_markup(str(exc))in ValueError and Exception handlers