Skip to content

fix: use missing_ok for temp file cleanup to avoid masking errors #3820

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
Quratulain-bilal wants to merge 2 commits into
base: main
Choose a base branch
from
+13 −6
Open

fix: use missing_ok for temp file cleanup to avoid masking errors #3820

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
a4bd37d
fix: use missing_ok for temp file cleanup to avoid masking errors
Quratulain-bilal Jul 28, 2026
c0d362c
fix: catch OSError during temp file cleanup to avoid masking errors
Quratulain-bilal Jul 29, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 5 additions & 2 deletions src/specify_cli/_utils.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -192,8 +192,11 @@ def atomic_write_json(target_file: Path, payload: dict[str, Any]) -> None:

os.replace(temp_path, target_file)
except Exception:
if temp_path and temp_path.exists():
temp_path.unlink()
if temp_path:
try:
temp_path.unlink(missing_ok=True)
except OSError:
pass
raise

try:
Expand Down
6 changes: 4 additions & 2 deletions src/specify_cli/integrations/manifest.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -451,8 +451,10 @@ def save(self) -> Path:
_ensure_safe_manifest_destination(self.project_root, path)
os.replace(temp_path, path)
finally:
if temp_path.exists():
temp_path.unlink()
try:
temp_path.unlink(missing_ok=True)
except OSError:
pass
return path

@classmethod
Expand Down
6 changes: 4 additions & 2 deletions src/specify_cli/shared_infra.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -262,8 +262,10 @@ def _write_shared_bytes(
_ensure_safe_shared_destination(project_path, dest)
os.replace(temp_path, dest)
finally:
if temp_path.exists():
temp_path.unlink()
try:
temp_path.unlink(missing_ok=True)
except OSError:
pass


_BASH_FORMAT_COMMAND_RE = re.compile(
Expand Down