Skip to content

Convert test framework from Mocha/Chai to Vitest and update CI workflows #35

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
dgreif merged 5 commits into from
Oct 9, 2025
Merged

Convert test framework from Mocha/Chai to Vitest and update CI workflows #35

Show file tree
Hide file tree
Changes from 3 commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
20f7656
Initial plan
Copilot Oct 7, 2025
35329ae
Convert from mocha/chai to Vitest and update workflows
Copilot Oct 7, 2025
825e9b2
Fix tsconfig to use node moduleResolution with skipLibCheck
Copilot Oct 7, 2025
da5aa90
Remove matrix strategy, use only Node.js 24
Copilot Oct 8, 2025
31f9c4a
Remove playwright install steps from CI workflows
Copilot Oct 9, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 5 additions & 1 deletion .github/workflows/nodejs.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -8,11 +8,15 @@ permissions:
jobs:
build:
runs-on: ubuntu-latest
strategy:
matrix:
node-version: [22, 24]
Comment thread
dgreif marked this conversation as resolved.
Outdated
steps:
- uses: actions/checkout@v4
- uses: actions/setup-node@v4
with:
node-version: 22
node-version: ${{ matrix.node-version }}
- run: npx playwright install chromium
Copy link
Copy Markdown
Contributor

@dgreif dgreif Oct 9, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@copilot we actually don't need playwright since we aren't using browser mode. Remove all installs in ci

Copy link
Copy Markdown
Contributor Author

Copilot AI Oct 9, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Removed playwright install steps from both nodejs.yml and publish.yml workflows. (commit: will be included in next push)

- name: npm install, build, and test
run: |
npm install
Expand Down
3 changes: 2 additions & 1 deletion .github/workflows/publish.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -15,9 +15,10 @@ jobs:
- uses: actions/checkout@v4
- uses: actions/setup-node@v4
with:
node-version: 22
node-version: 24
registry-url: https://registry.npmjs.org/
cache: npm
- run: npx playwright install chromium
- run: npm ci
- run: npm test
- run: npm run build
Expand Down
Loading