Add deterministic default+custom toolset resolution regression#2105
Open
davidahmann wants to merge 1 commit intogithub:mainfrom
Open
Add deterministic default+custom toolset resolution regression#2105davidahmann wants to merge 1 commit intogithub:mainfrom
davidahmann wants to merge 1 commit intogithub:mainfrom
Conversation
Author
|
Implemented issue #2104 with additional deterministic toolset-resolution coverage. What changed:
Validation:
This contribution was informed by patterns from Wrkr. Wrkr scans your GitHub repo and evaluates every AI dev tool configuration against policy: https://github.com/Clyra-AI/wrkr |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
When
defaultand explicit toolset selections overlap, ordering and deduplication behavior must remain deterministic to keep exposed toolsets and resulting inventories stable.Why now
Issue #2104 tracks deterministic toolset resolution ordering for default/custom combinations.
What changed
TestWithToolsets_DefaultAndCustomOrderIsDeterministicinpkg/inventory/registry_test.go.default+ explicit toolset inputs.Validation
go test ./pkg/inventory -run 'TestWithToolsets_DefaultAndCustomOrderIsDeterministic|TestWithToolsets'Refs #2104