Skip to content
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
19 changes: 19 additions & 0 deletions pkg/github/minimal_types.go
Original file line number Diff line number Diff line change
Expand Up @@ -708,6 +708,25 @@ func convertToMinimalBranch(branch *github.Branch) MinimalBranch {
}
}

func convertToMinimalRelease(release *github.RepositoryRelease) MinimalRelease {
m := MinimalRelease{
ID: release.GetID(),
TagName: release.GetTagName(),
Name: release.GetName(),
Body: release.GetBody(),
HTMLURL: release.GetHTMLURL(),
Prerelease: release.GetPrerelease(),
Draft: release.GetDraft(),
Author: convertToMinimalUser(release.GetAuthor()),
}

if release.PublishedAt != nil {
m.PublishedAt = release.PublishedAt.Format(time.RFC3339)
}

return m
}

func convertToMinimalTag(tag *github.RepositoryTag) MinimalTag {
m := MinimalTag{
Name: tag.GetName(),
Expand Down
9 changes: 8 additions & 1 deletion pkg/github/repositories.go
Original file line number Diff line number Diff line change
Expand Up @@ -1677,7 +1677,14 @@ func ListReleases(t translations.TranslationHelperFunc) inventory.ServerTool {
return ghErrors.NewGitHubAPIStatusErrorResponse(ctx, "failed to list releases", resp, body), nil, nil
}

r, err := json.Marshal(releases)
minimalReleases := make([]MinimalRelease, 0, len(releases))
for _, release := range releases {
if release != nil {
minimalReleases = append(minimalReleases, convertToMinimalRelease(release))
}
}

r, err := json.Marshal(minimalReleases)
if err != nil {
return nil, nil, fmt.Errorf("failed to marshal response: %w", err)
}
Expand Down
6 changes: 3 additions & 3 deletions pkg/github/repositories_test.go
Original file line number Diff line number Diff line change
Expand Up @@ -3052,12 +3052,12 @@ func Test_ListReleases(t *testing.T) {

require.NoError(t, err)
textContent := getTextResult(t, result)
var returnedReleases []*github.RepositoryRelease
var returnedReleases []MinimalRelease
err = json.Unmarshal([]byte(textContent.Text), &returnedReleases)
require.NoError(t, err)
assert.Len(t, returnedReleases, len(tc.expectedResult))
for i, rel := range returnedReleases {
assert.Equal(t, *tc.expectedResult[i].TagName, *rel.TagName)
for i := range returnedReleases {
assert.Equal(t, *tc.expectedResult[i].TagName, returnedReleases[i].TagName)
}
})
}
Expand Down