fix: keep all resources registered for resources/read requests #1792
+7
−22
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The ForMCPRequest optimization was incorrectly filtering resources by
doing an exact string match between the URI template pattern and the
concrete URI. This would never match because templates like
'repo://{owner}/{repo}/contents{/path*}' don't match concrete URIs
like 'repo://owner/repo/contents/file.py'.
Instead of implementing template matching in the inventory, we simply
keep all resources registered for resources/read requests and let the
SDK handle URI template matching internally (which it already does
correctly via uritemplate.Regexp().MatchString()).
This fixes resources/read returning 'Resource not found' for valid URIs.
Contributor
There was a problem hiding this comment.
Pull request overview
This PR fixes a bug where resources/read requests incorrectly returned "Resource not found" errors for valid URIs when using the ForMCPRequest optimization in the remote server scenario.
Changes:
- Removed incorrect URI filtering logic that performed exact string matching between URI templates and concrete URIs (which never matched)
- Updated
ForMCPRequestto keep all resources registered forresources/readrequests, delegating URI template matching to the SDK - Updated test expectations and documentation to reflect the new behavior
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| pkg/inventory/registry.go | Removed broken filterResourcesByURI call in ForMCPRequest for MCPMethodResourcesRead case; updated doc comment to document that SDK handles matching |
| pkg/inventory/registry_test.go | Updated TestForMCPRequest_ResourcesRead to pass concrete URI and expect all resources to be available (SDK handles matching) |
mattdholloway
approved these changes
Jan 12, 2026
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Fixes
resources/readreturning "Resource not found" for valid URIs when usingForMCPRequestoptimization.Problem
The
ForMCPRequestoptimization was incorrectly filtering resources by doing an exact string match between the URI template pattern and the concrete URI infilterResourcesByURI:This would never match because:
repo://{owner}/{repo}/contents{/path*}repo://SamMorrowDrums/remarkable-mcp/contents/server.pySolution
Instead of implementing template matching in the inventory, we simply keep all resources registered for
resources/readrequests and let the SDK handle URI template matching internally (which it already does correctly viauritemplate.Regexp().MatchString()).This is the same approach used for
resources/listandresources/templates/list.Changes
ForMCPRequestno longer filters resources forMCPMethodResourcesReadTesting
AddResourceTemplatecorrectly matches URIs using RFC 6570 template patterns