-
Notifications
You must be signed in to change notification settings - Fork 467
Stabilize smoke-copilot-auto lock output by skipping dynamic auto pricing injection
#48516
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Changes from all commits
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -15,17 +15,10 @@ func hasModelPricingResolver(compiler *workflow.Compiler) bool { | |
| return !reflect.ValueOf(compiler).Elem().FieldByName("modelPricingResolver").IsNil() | ||
| } | ||
|
|
||
| func TestCreateAndConfigureCompiler_RegistersModelPricingResolverByDefault(t *testing.T) { | ||
| func TestCreateAndConfigureCompiler_DoesNotRegisterModelPricingResolverByDefault(t *testing.T) { | ||
| compiler := createAndConfigureCompiler(CompileConfig{}) | ||
| if !hasModelPricingResolver(compiler) { | ||
| t.Fatal("expected model pricing resolver to be registered by default") | ||
| } | ||
| } | ||
|
|
||
| func TestCreateAndConfigureCompiler_SkipsModelPricingResolverWhenDisabled(t *testing.T) { | ||
| compiler := createAndConfigureCompiler(CompileConfig{DisableModelsDevLookup: true}) | ||
| if hasModelPricingResolver(compiler) { | ||
|
Contributor
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. The test name @copilot please address this.
Contributor
Author
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Renamed to |
||
| t.Fatal("expected model pricing resolver to be nil when models.dev lookup is disabled") | ||
| t.Fatal("expected model pricing resolver to be nil by default") | ||
|
Contributor
Author
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. This was a deliberate change per the explicit user request to "remove dynamic pricing lookup all together." Removing the resolver entirely — not just skipping it for |
||
| } | ||
| } | ||
|
|
||
|
|
||
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The
--no-models-dev-lookupflag controlled the now-removedmodels.devpricing resolver. With the resolver gone, the flag has no associated functionality and was removed intentionally. Any scripts using it would have had no effect after the resolver was removed, so removing the flag keeps the CLI surface clean and avoids a dead option.