linters: add bytescomparezero analyzer for bytes.Compare(... ) == 0 equality checks

[Copilot]

Adds a new custom Go analyzer, bytescomparezero, to catch equality-style bytes.Compare usage and suggest the idiomatic bytes.Equal form. This closes a readability/intent gap while preserving non-equality compare semantics.

• Analyzer implementation (pkg/linters/bytescomparezero)

  • Detects:
    • bytes.Compare(a, b) == 0
    • bytes.Compare(a, b) != 0
    • 0 == bytes.Compare(a, b) (yoda form)
    • 0 != bytes.Compare(a, b) (yoda form)
  • Suggests fix to:
    • bytes.Equal(a, b)
    • !bytes.Equal(a, b)
  • Intentionally ignores ordering/other comparisons (< 0, > 0, == 1, etc.).
  • Honors //nolint:bytescomparezero and skips generated files.
  • Preserves import aliasing (bx.Compare -> bx.Equal).

• Registration and docs sync

  • Registers bytescomparezero in pkg/linters/registry.go.
  • Updates linter surfaces in:
    • pkg/linters/doc.go (analyzer list/count)
    • pkg/linters/README.md (subpackage + overview entries)
    • pkg/linters/spec_test.go (documented analyzer set)

• Linter fixtures

  • Adds analysistest cases and goldens covering normal, yoda, alias, nolint, and generated-file scenarios.

// before
if bytes.Compare(a, b) == 0 { ... }
if 0 != bytes.Compare(a, b) { ... }

// after
if bytes.Equal(a, b) { ... }
if !bytes.Equal(a, b) { ... }

• Fixes [linter-miner] linters: add bytescomparezero linter #48417

[Copilot]

Pull request overview

Adds and registers the bytescomparezero Go analyzer to replace equality-oriented bytes.Compare checks with idiomatic bytes.Equal.

Changes:

• Implements detection, suppression, generated-file skipping, and suggested fixes.
• Adds analyzer fixtures and documentation/registry synchronization.
• Refreshes generated workflow metadata.

Show a summary per file

File	Description
pkg/linters/bytescomparezero/bytescomparezero.go	Implements the analyzer and fixes.
pkg/linters/bytescomparezero/bytescomparezero_test.go	Runs analyzer fixture tests.
pkg/linters/bytescomparezero/testdata/src/bytescomparezero/bytescomparezero.go	Adds primary test cases.
pkg/linters/bytescomparezero/testdata/src/bytescomparezero/bytescomparezero.go.golden	Defines expected rewrites.
pkg/linters/bytescomparezero/testdata/src/bytescomparezero/aliased_import.go	Tests aliased imports.
pkg/linters/bytescomparezero/testdata/src/bytescomparezero/aliased_import.go.golden	Defines alias-preserving rewrites.
pkg/linters/bytescomparezero/testdata/src/bytescomparezero/generated.go	Verifies generated files are skipped.
pkg/linters/registry.go	Registers the analyzer.
pkg/linters/spec_test.go	Adds it to documented analyzer checks.
pkg/linters/doc.go	Documents the analyzer and updates the count.
pkg/linters/README.md	Adds public package documentation.
.github/workflows/smoke-copilot-auto.lock.yml	Adds generated model-cost metadata.

Review details

Tip

Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Files not reviewed (1)

• pkg/linters/bytescomparezero/testdata/src/bytescomparezero/generated.go: Generated file

• Files reviewed: 11/12 changed files
• Comments generated: 1
• Review effort level: Medium

[pelikhan]

@copilot resolve the merge conflicts on this branch.