Move model alias/multiplier propagation from step env to activation artifact file#34837
Conversation
Co-authored-by: pelikhan <4175913+pelikhan@users.noreply.github.com>
Co-authored-by: pelikhan <4175913+pelikhan@users.noreply.github.com>
Co-authored-by: pelikhan <4175913+pelikhan@users.noreply.github.com>
|
🧪 Test Quality Sentinel completed test quality analysis. |
|
✅ PR Code Quality Reviewer completed the code quality review. |
|
✅ Design Decision Gate 🏗️ completed the design decision gate check. No ADR enforcement needed: PR #34837 does not have the 'implementation' label and has only 10 new lines (≤100) in default business logic directories. |
|
🧠 Matt Pocock Skills Reviewer has completed the skills-based review. ✅ |
There was a problem hiding this comment.
Pull request overview
This PR moves model alias/multiplier propagation from step environment variables to a file-based flow rooted in the activation artifact, reducing compiled log/env churn and making downstream jobs read a consistent materialized payload from disk.
Changes:
- Activation job now writes
/tmp/gh-aw/model_multipliers.json(built-in multipliers merged withGH_AW_INFO_TOKEN_WEIGHTS) and uploads it in the activation artifact. - Runtime ET logic (
effective_tokens.cjs) now resolves multipliers in order: merged file →GH_AW_MODEL_MULTIPLIERSenv fallback → built-inmodel_multipliers.json. - Setup no longer exports the large
GH_AW_MODEL_MULTIPLIERSJSON intoGITHUB_ENV; tests and golden fixtures are updated accordingly.
Show a summary per file
| File | Description |
|---|---|
| pkg/workflow/compiler_activation_job_builder.go | Upload activation artifact now includes /tmp/gh-aw/model_multipliers.json. |
| actions/setup/setup.sh | Removes exporting GH_AW_MODEL_MULTIPLIERS into job env. |
| actions/setup/js/generate_aw_info.cjs | Writes merged multipliers file into /tmp/gh-aw/ during activation. |
| actions/setup/js/generate_aw_info.test.cjs | Adds coverage for merged multipliers file creation and override merge behavior. |
| actions/setup/js/effective_tokens.cjs | Adds file/env/built-in precedence for multipliers resolution. |
| actions/setup/js/effective_tokens.test.cjs | Updates tests to reflect new precedence (including built-in fallback). |
| actions/setup/js/parse_mcp_gateway_log.cjs | Updates doc comment for ET multiplier data source. |
| pkg/workflow/testdata/TestWasmGolden_CompileFixtures/with-imports.golden | Golden updated to include the new artifact path. |
| pkg/workflow/testdata/TestWasmGolden_CompileFixtures/smoke-copilot.golden | Golden updated to include the new artifact path. |
| pkg/workflow/testdata/TestWasmGolden_CompileFixtures/playwright-cli-mode.golden | Golden updated to include the new artifact path. |
| pkg/workflow/testdata/TestWasmGolden_CompileFixtures/basic-copilot.golden | Golden updated to include the new artifact path. |
| pkg/workflow/testdata/TestWasmGolden_AllEngines/pi.golden | Golden updated to include the new artifact path. |
| pkg/workflow/testdata/TestWasmGolden_AllEngines/gemini.golden | Golden updated to include the new artifact path. |
| pkg/workflow/testdata/TestWasmGolden_AllEngines/copilot.golden | Golden updated to include the new artifact path. |
| pkg/workflow/testdata/TestWasmGolden_AllEngines/codex.golden | Golden updated to include the new artifact path. |
| pkg/workflow/testdata/TestWasmGolden_AllEngines/claude.golden | Golden updated to include the new artifact path. |
Copilot's findings
Tip
Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
- Files reviewed: 16/16 changed files
- Comments generated: 3
| if (Object.prototype.hasOwnProperty.call(process.env, "GH_AW_MODEL_MULTIPLIERS")) { | ||
| const raw = process.env.GH_AW_MODEL_MULTIPLIERS; | ||
| if (raw && raw.trim()) { | ||
| const parsedFromEnv = parseMultipliersJSON(raw); | ||
| if (parsedFromEnv) { | ||
| _parsedMultipliers = parsedFromEnv; | ||
| return _parsedMultipliers; | ||
| } | ||
| } | ||
| _parsedMultipliers = null; | ||
| return null; | ||
| } |
| beforeEach(() => { | ||
| _resetCache(); | ||
| if (fs.existsSync(MERGED_MULTIPLIERS_PATH)) { | ||
| fs.unlinkSync(MERGED_MULTIPLIERS_PATH); | ||
| } |
| * Parses token-usage.jsonl content and returns an aggregated summary. | ||
| * Computes effective tokens (ET) per model using the GH_AW_MODEL_MULTIPLIERS env var. | ||
| * Computes effective tokens (ET) per model using merged/built-in model multipliers data. | ||
| * @param {string} jsonlContent - The token-usage.jsonl file content |
🧪 Test Quality Sentinel Report✅ Test Quality Score: 90/100 — Excellent
📊 Metrics & Test Classification (3 tests analyzed)
Test Classification Details
Language SupportTests analyzed:
Verdict
📖 Understanding Test ClassificationsDesign Tests (High Value) verify what the system does:
Implementation Tests (Low Value) verify how the system does it:
Goal: Shift toward tests that describe the system's behavioral contract — the promises it makes to its users and collaborators.
|
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
There was a problem hiding this comment.
Skills-Based Review 🧠
Applied /zoom-out, /improve-codebase-architecture, and /tdd — commenting with non-blocking suggestions.
📋 Key Themes & Highlights
Key Themes
- Lookup precedence edge case: When
GH_AW_MODEL_MULTIPLIERSis present but empty/invalid, the built-in file tier is silently skipped. This may be intentional but diverges from the documented 3-tier spec and is untested. - Scoping inconsistency:
parseTokenWeightsFromEnvandwriteMergedModelMultipliersare defined insidemain()whilegetPlainObjectOrEmptylives at module scope — inconsistent placement for large, reusable helpers. - Duplicate plain-object guard:
isPlainObjectineffective_tokens.cjsandgetPlainObjectOrEmptyingenerate_aw_info.cjsimplement identical logic — good candidate for a shared utility. - Minor: JSDoc cast in
getPlainObjectOrEmptyis missing parentheses around the expression.
Positive Highlights
- ✅ Solid architectural move — file-based artifact propagation is cleaner than injecting large JSON blobs into job environment variables.
- ✅ Compatibility fallback retained for
GH_AW_MODEL_MULTIPLIERS— smooth migration path for any existing consumers. - ✅ Good test additions in
generate_aw_info.test.cjscovering the merge/write path and custom override case. - ✅
isPlainObjectandparseMultipliersFile/parseMultipliersJSONextraction improves readability ineffective_tokens.cjs. - ✅ All golden files updated, confirming the compiler change is reflected end-to-end.
🧠 Reviewed using Matt Pocock's skills by Matt Pocock Skills Reviewer · sonnet46 1.5M
| return _parsedMultipliers; | ||
| } | ||
| } | ||
| _parsedMultipliers = null; |
There was a problem hiding this comment.
[/zoom-out] Silent null-return when env var is present but invalid skips the built-in file fallback.
If GH_AW_MODEL_MULTIPLIERS is set to "" or contains invalid JSON, the function returns null without attempting the built-in file. This differs from the documented 3-tier lookup — tier 3 (built-in file) is unreachable whenever the env var key exists, even with an unusable value.
💡 Suggested fix
Continue to the next tier on invalid/empty value:
if (Object.prototype.hasOwnProperty.call(process.env, "GH_AW_MODEL_MULTIPLIERS")) {
const raw = process.env.GH_AW_MODEL_MULTIPLIERS;
if (raw && raw.trim()) {
const parsedFromEnv = parseMultipliersJSON(raw);
if (parsedFromEnv) {
_parsedMultipliers = parsedFromEnv;
return _parsedMultipliers;
}
// invalid JSON — fall through to built-in
}
// env var present but empty — fall through to built-in
}Alternatively, document explicitly that a set-but-invalid env var intentionally blocks the built-in tier.
|
|
||
| test("returns 1.0 when env var is not set", () => { | ||
| test("falls back to built-in multipliers when env var is not set", () => { | ||
| _resetCache(); |
There was a problem hiding this comment.
[/tdd] Missing edge-case test: env var present but invalid, merged file absent — should verify which multipliers (built-in or none) are returned.
The test on line 130 renames the old 'returns 1.0 when env var is not set' case but doesn't add a complementary test for when the env var is set but contains invalid JSON (and the merged file doesn't exist).
💡 Suggested test
test("returns null (no built-in fallback) when GH_AW_MODEL_MULTIPLIERS is set to invalid JSON", () => {
_resetCache();
process.env.GH_AW_MODEL_MULTIPLIERS = "not-json";
// merged file already absent (cleaned in beforeEach)
expect(getModelMultiplier("claude-opus-4.5")).toBe(1.0); // or toBeGreaterThan(1.0) if built-in should still apply
});This pins the intended behaviour so it can't silently regress.
|
|
||
| // Write to /tmp/gh-aw directory to avoid inclusion in PR | ||
| fs.mkdirSync(TMP_GH_AW_PATH, { recursive: true }); | ||
| writeMergedModelMultipliers(core, tokenWeights); |
There was a problem hiding this comment.
[/improve-codebase-architecture] writeMergedModelMultipliers is called before its declaration (relies on JS function hoisting) and is nested inside main() alongside parseTokenWeightsFromEnv.
Defining large helper functions inside an async top-level function makes the module harder to navigate — readers expect to see them near top-of-file or at module level, not buried after several hundred lines of main(). Both helpers have no closure state and could trivially be lifted to module scope.
💡 Suggested refactor
Move parseTokenWeightsFromEnv and writeMergedModelMultipliers to module scope (outside main), the same way getPlainObjectOrEmpty is already defined at module level. The call in main stays the same; only the function definition moves.
| /** | ||
| * @param {unknown} value | ||
| * @returns {Record<string, unknown>} | ||
| */ |
There was a problem hiding this comment.
[/improve-codebase-architecture] getPlainObjectOrEmpty duplicates the plain-object guard already extracted as isPlainObject in effective_tokens.cjs.
Both files now implement the same value !== null && typeof value === 'object' && !Array.isArray(value) pattern independently. A shared utils.cjs or object_utils.cjs module would prevent this drift.
💡 Suggested approach
Extract to a shared file, e.g. actions/setup/js/object_utils.cjs:
/** `@param` {unknown} v `@returns` {v is Record<string, unknown>} */
function isPlainObject(v) {
return v !== null && typeof v === "object" && !Array.isArray(v);
}
/** `@param` {unknown} v `@returns` {Record<string, unknown>} */
function toPlainObjectOrEmpty(v) {
return isPlainObject(v) ? /** `@type` {Record<string, unknown>} */ (v) : {};
}
module.exports = { isPlainObject, toPlainObjectOrEmpty };Both files can then require the shared helpers.
| module.exports = { main }; | ||
|
|
||
| /** | ||
| * @param {unknown} value |
There was a problem hiding this comment.
[/improve-codebase-architecture] JSDoc cast is missing parentheses — /** @type */ value instead of /** @type */ (value).
The standard JSDoc type-assertion form requires wrapping the expression in parentheses: /** @type {T} */ (expr). Without parens, some type checkers and linters misparse the annotation.
💡 Fix
// Before
return /** `@type` {Record<string, unknown>} */ value;
// After
return /** `@type` {Record<string, unknown>} */ (value);
There was a problem hiding this comment.
REQUEST_CHANGES — 1 high + 3 medium issues found across the ET/multiplier refactor.
### Issues summary
High
Number(mult)inparseMultipliersJSONstoresNaNwithout aNumber.isFiniteguard; any non-numeric value in a multipliers file silently poisons ET calculations for that model.
Medium
getMultipliersData(): whenGH_AW_MODEL_MULTIPLIERSis set but empty or invalid, the function returnsnulland skips the built-in file. The three-tier fallback described in the PR collapses to two for anyone with the env var exported (even empty).getPlainObjectOrEmpty: JSDoc cast/**@type{T} */ valueis missing parentheses — the assertion has no effect and the inferred return type remainsunknown.writeMergedModelMultipliers:fs.writeFileSyncis unguarded; a write failure propagates as an uncaught exception with nocore.setFaileddiagnostic, unlike the read paths above it.
Overall direction (activation-artifact file over env-var injection) is sound. Fix the Number.isFinite guard and the env-var fallback logic before merging.
🔎 Code quality review by PR Code Quality Reviewer · sonnet46 2.8M
| multipliers[model.toLowerCase()] = Number(mult); | ||
| if (isPlainObject(parsed.multipliers)) { | ||
| for (const [model, mult] of Object.entries(parsed.multipliers)) { | ||
| multipliers[model.toLowerCase()] = Number(mult); |
There was a problem hiding this comment.
Number(mult) stores NaN without validation, silently corrupting multiplier lookups.
Any non-numeric multiplier value (string, object, null) becomes NaN in the map. Downstream getModelMultiplier() returns NaN, causing all ET calculations for that model to silently produce NaN instead of falling back to 1.0.
💡 Suggested fix
const numMult = Number(mult);
if (Number.isFinite(numMult)) {
multipliers[model.toLowerCase()] = numMult;
}This is the same guard already applied to token_class_weights entries a few lines above — consistent and cheap.
| } | ||
| } | ||
| _parsedMultipliers = null; | ||
| return null; |
There was a problem hiding this comment.
When GH_AW_MODEL_MULTIPLIERS is set but empty or invalid, the built-in file fallback is silently skipped.
The hasOwnProperty guard at line 56 treats any presence of the env var — including GH_AW_MODEL_MULTIPLIERS="" or invalid JSON — as an explicit override: it sets _parsedMultipliers = null and returns without reaching the built-in file path. A caller that exports the env var as empty (e.g. from a template) will get null multipliers permanently, even though model_multipliers.json is right there.
💡 Suggested fix
Fall through to the built-in when the env var is present but not parseable:
if (Object.prototype.hasOwnProperty.call(process.env, "GH_AW_MODEL_MULTIPLIERS")) {
const raw = process.env.GH_AW_MODEL_MULTIPLIERS;
if (raw && raw.trim()) {
const parsedFromEnv = parseMultipliersJSON(raw);
if (parsedFromEnv) {
_parsedMultipliers = parsedFromEnv;
return _parsedMultipliers;
}
}
// env var present but empty/invalid — fall through to built-in
}Only cache null after all three sources have been exhausted.
| */ | ||
| function getPlainObjectOrEmpty(value) { | ||
| if (value && typeof value === "object" && !Array.isArray(value)) { | ||
| return /** @type {Record<string, unknown>} */ value; |
There was a problem hiding this comment.
Incorrect JSDoc cast syntax — type assertion has no effect without parentheses.
/** @type {T} */ value is a comment before an expression; it does not cast in JSDoc/TypeScript. Without parentheses, the type annotation is silently ignored and the return type is inferred as unknown, defeating the @returns {Record<string, unknown>} contract.
💡 Suggested fix
return /** `@type` {Record<string, unknown>} */ (value);The parentheses are required for JSDoc type-casts to be recognized by TypeScript and type-aware editors.
| }; | ||
|
|
||
| const mergedPath = `${TMP_GH_AW_PATH}/model_multipliers.json`; | ||
| fs.writeFileSync(mergedPath, JSON.stringify(merged, null, 2)); |
There was a problem hiding this comment.
fs.writeFileSync failure is unhandled and will crash the activation job step with a raw stack trace.
The read paths above have try/catch + core.warning, but the write does not. A disk-full or unexpected permission error will propagate as an uncaught exception from inside main, failing the step with no actionable diagnostic.
💡 Suggested fix
try {
fs.writeFileSync(mergedPath, JSON.stringify(merged, null, 2));
core.info(`Generated merged model multipliers at: ${mergedPath}`);
} catch (error) {
core.setFailed(`Failed to write merged model multipliers: ${String(error)}`);
}There was a problem hiding this comment.
Smoke reply test. Me answer old review thread with tiny footprint.
Warning
Firewall blocked 6 domains
The following domains were blocked by the firewall during workflow execution:
accounts.google.comandroid.clients.google.comclients2.google.comcontentautofill.googleapis.comsafebrowsingohttpgateway.googleapis.comwww.google.com
To allow these domains, add them to the
network.allowedlist in your workflow frontmatter:
network:
allowed:
- defaults
- "accounts.google.com"
- "android.clients.google.com"
- "clients2.google.com"
- "contentautofill.googleapis.com"
- "safebrowsingohttpgateway.googleapis.com"
- "www.google.com"See Network Configuration for more information.
📰 BREAKING: Report filed by Smoke Copilot · gpt55 4M
|
@copilot review ALL comments and review comments. Respond with resolution and resolve review comments. |
Co-authored-by: pelikhan <4175913+pelikhan@users.noreply.github.com>
Co-authored-by: pelikhan <4175913+pelikhan@users.noreply.github.com>
Addressed all three review threads in b94fd19:
|
|
@copilot update compiler to stop online the full model info in env variables. Only needed if workflow has custom models |
Co-authored-by: pelikhan <4175913+pelikhan@users.noreply.github.com>
…aliases-and-multipliers # Conflicts: # .github/workflows/ab-testing-advisor.lock.yml # .github/workflows/agent-performance-analyzer.lock.yml # .github/workflows/agent-persona-explorer.lock.yml # .github/workflows/agentic-token-audit.lock.yml # .github/workflows/archie.lock.yml # .github/workflows/architecture-guardian.lock.yml # .github/workflows/artifacts-summary.lock.yml # .github/workflows/auto-triage-issues.lock.yml # .github/workflows/aw-portfolio-yield.lock.yml # .github/workflows/brave.lock.yml # .github/workflows/breaking-change-checker.lock.yml # .github/workflows/chaos-pr-bundle-fuzzer.lock.yml # .github/workflows/ci-coach.lock.yml # .github/workflows/cli-consistency-checker.lock.yml # .github/workflows/code-scanning-fixer.lock.yml # .github/workflows/code-simplifier.lock.yml # .github/workflows/constraint-solving-potd.lock.yml # .github/workflows/contribution-check.lock.yml # .github/workflows/copilot-cli-deep-research.lock.yml # .github/workflows/copilot-opt.lock.yml # .github/workflows/copilot-pr-merged-report.lock.yml # .github/workflows/copilot-pr-nlp-analysis.lock.yml # .github/workflows/copilot-pr-prompt-analysis.lock.yml # .github/workflows/craft.lock.yml # .github/workflows/daily-agent-of-the-day-blog-writer.lock.yml # .github/workflows/daily-architecture-diagram.lock.yml # .github/workflows/daily-assign-issue-to-user.lock.yml # .github/workflows/daily-cache-strategy-analyzer.lock.yml # .github/workflows/daily-cli-performance.lock.yml # .github/workflows/daily-cli-tools-tester.lock.yml # .github/workflows/daily-community-attribution.lock.yml # .github/workflows/daily-compiler-quality.lock.yml # .github/workflows/daily-experiment-report.lock.yml # .github/workflows/daily-fact.lock.yml # .github/workflows/daily-file-diet.lock.yml # .github/workflows/daily-firewall-report.lock.yml # .github/workflows/daily-geo-optimizer.lock.yml # .github/workflows/daily-hippo-learn.lock.yml # .github/workflows/daily-issues-report.lock.yml # .github/workflows/daily-mcp-concurrency-analysis.lock.yml # .github/workflows/daily-model-inventory.lock.yml # .github/workflows/daily-news.lock.yml # .github/workflows/daily-observability-report.lock.yml # .github/workflows/daily-performance-summary.lock.yml # .github/workflows/daily-regulatory.lock.yml # .github/workflows/daily-repo-chronicle.lock.yml # .github/workflows/daily-safe-output-integrator.lock.yml # .github/workflows/daily-secrets-analysis.lock.yml # .github/workflows/daily-security-observability.lock.yml # .github/workflows/daily-semgrep-scan.lock.yml # .github/workflows/daily-sentrux-report.lock.yml # .github/workflows/daily-skill-optimizer.lock.yml # .github/workflows/daily-spdd-spec-planner.lock.yml # .github/workflows/daily-syntax-error-quality.lock.yml # .github/workflows/daily-team-status.lock.yml # .github/workflows/daily-testify-uber-super-expert.lock.yml # .github/workflows/daily-workflow-updater.lock.yml # .github/workflows/dataflow-pr-discussion-dataset.lock.yml # .github/workflows/dead-code-remover.lock.yml # .github/workflows/delight.lock.yml # .github/workflows/dependabot-burner.lock.yml # .github/workflows/dependabot-campaign.lock.yml # .github/workflows/dependabot-go-checker.lock.yml # .github/workflows/dependabot-repair.lock.yml # .github/workflows/dependabot-worker.lock.yml # .github/workflows/deployment-incident-monitor.lock.yml # .github/workflows/dev-hawk.lock.yml # .github/workflows/dev.lock.yml # .github/workflows/dictation-prompt.lock.yml # .github/workflows/discussion-task-miner.lock.yml # .github/workflows/docs-noob-tester.lock.yml # .github/workflows/draft-pr-cleanup.lock.yml # .github/workflows/duplicate-code-detector.lock.yml # .github/workflows/firewall-escape.lock.yml # .github/workflows/functional-pragmatist.lock.yml # .github/workflows/github-remote-mcp-auth-test.lock.yml # .github/workflows/glossary-maintainer.lock.yml # .github/workflows/gpclean.lock.yml # .github/workflows/grumpy-reviewer.lock.yml # .github/workflows/issue-arborist.lock.yml # .github/workflows/issue-monster.lock.yml # .github/workflows/issue-triage-agent.lock.yml # .github/workflows/jsweep.lock.yml # .github/workflows/layout-spec-maintainer.lock.yml # .github/workflows/lint-monster.lock.yml # .github/workflows/linter-miner.lock.yml # .github/workflows/mattpocock-skills-reviewer.lock.yml # .github/workflows/mcp-inspector.lock.yml # .github/workflows/mergefest.lock.yml # .github/workflows/metrics-collector.lock.yml # .github/workflows/necromancer.lock.yml # .github/workflows/notion-issue-summary.lock.yml # .github/workflows/org-health-report.lock.yml # .github/workflows/otlp-data-quality-validator.lock.yml # .github/workflows/outcome-collector.lock.yml # .github/workflows/pdf-summary.lock.yml # .github/workflows/plan.lock.yml # .github/workflows/poem-bot.lock.yml # .github/workflows/pr-code-quality-reviewer.lock.yml # .github/workflows/pr-description-caveman.lock.yml # .github/workflows/pr-nitpick-reviewer.lock.yml # .github/workflows/pr-sous-chef.lock.yml # .github/workflows/pr-triage-agent.lock.yml # .github/workflows/python-data-charts.lock.yml # .github/workflows/q.lock.yml # .github/workflows/refactoring-cadence.lock.yml # .github/workflows/refiner.lock.yml # .github/workflows/repo-audit-analyzer.lock.yml # .github/workflows/repo-tree-map.lock.yml # .github/workflows/repository-quality-improver.lock.yml # .github/workflows/research.lock.yml # .github/workflows/schema-feature-coverage.lock.yml # .github/workflows/security-compliance.lock.yml # .github/workflows/security-review.lock.yml # .github/workflows/slide-deck-maintainer.lock.yml # .github/workflows/smoke-call-workflow.lock.yml # .github/workflows/smoke-codex.lock.yml # .github/workflows/smoke-copilot-arm.lock.yml # .github/workflows/smoke-copilot.lock.yml # .github/workflows/smoke-create-cross-repo-pr.lock.yml # .github/workflows/smoke-multi-pr.lock.yml # .github/workflows/smoke-otel-backends.lock.yml # .github/workflows/smoke-project.lock.yml # .github/workflows/smoke-service-ports.lock.yml # .github/workflows/smoke-temporary-id.lock.yml # .github/workflows/smoke-test-tools.lock.yml # .github/workflows/smoke-update-cross-repo-pr.lock.yml # .github/workflows/smoke-workflow-call-with-inputs.lock.yml # .github/workflows/smoke-workflow-call.lock.yml # .github/workflows/spec-extractor.lock.yml # .github/workflows/spec-librarian.lock.yml # .github/workflows/stale-pr-cleanup.lock.yml # .github/workflows/stale-repo-identifier.lock.yml # .github/workflows/sub-issue-closer.lock.yml # .github/workflows/super-linter.lock.yml # .github/workflows/technical-doc-writer.lock.yml # .github/workflows/terminal-stylist.lock.yml # .github/workflows/test-dispatcher.lock.yml # .github/workflows/test-project-url-default.lock.yml # .github/workflows/test-quality-sentinel.lock.yml # .github/workflows/tidy.lock.yml # .github/workflows/ubuntu-image-analyzer.lock.yml # .github/workflows/uk-ai-operational-resilience.lock.yml # .github/workflows/update-astro.lock.yml # .github/workflows/video-analyzer.lock.yml # .github/workflows/visual-regression-checker.lock.yml # .github/workflows/weekly-blog-post-writer.lock.yml # .github/workflows/weekly-editors-health-check.lock.yml # .github/workflows/weekly-issue-summary.lock.yml # .github/workflows/weekly-safe-outputs-spec-review.lock.yml # .github/workflows/workflow-generator.lock.yml # .github/workflows/workflow-health-manager.lock.yml # .github/workflows/workflow-normalizer.lock.yml # .github/workflows/workflow-skill-extractor.lock.yml Co-authored-by: pelikhan <4175913+pelikhan@users.noreply.github.com>
|
🚀 Smoke Pi MISSION COMPLETE! Pi delivered. 🥧 |
|
🚀 Smoke Gemini MISSION COMPLETE! Gemini has spoken. ✨ Testing safeoutputs CLI |
|
🎬 THE END — Smoke Claude MISSION: ACCOMPLISHED! The hero saves the day! ✨ |
|
✨ The prophecy is fulfilled... Smoke Codex has completed its mystical journey. The stars align. 🌟 |
|
🚀 Smoke Antigravity MISSION COMPLETE! Antigravity has spoken. ✨ |
|
📰 BREAKING: Smoke Copilot is now investigating this pull request. Sources say the story is developing... |
Agent Container Tool Check
Result: 12/12 tools available ✅ Overall Status: PASS
|
Smoke Test Results\n- GitHub MCP Testing: ✅\n- Web Fetch Testing: ✅\n- File Writing Testing: ✅\n- Bash Tool Testing: ✅\n- Build gh-aw: ❌\n\nOverall Status: FAILWarning Firewall blocked 1 domainThe following domain was blocked by the firewall during workflow execution:
network:
allowed:
- defaults
- "localhost"See Network Configuration for more information.
|
|
Smoke test FAIL Checked merged PRs: Key failure: web-fetch MCP tool unavailable. Overall: FAIL Warning Firewall blocked 6 domainsThe following domains were blocked by the firewall during workflow execution:
network:
allowed:
- defaults
- "accounts.google.com"
- "android.clients.google.com"
- "clients2.google.com"
- "contentautofill.googleapis.com"
- "safebrowsingohttpgateway.googleapis.com"
- "www.google.com"See Network Configuration for more information.
|
💥 Smoke Test: Claude — Run 26505735356Core #1–13: ✅✅✅✅✅✅✅✅✅✅✅✅✅ Overall: PARTIAL (1 skipped, 0 failed) — run Warning Firewall blocked 6 domainsThe following domains were blocked by the firewall during workflow execution:
network:
allowed:
- defaults
- "accounts.google.com"
- "android.clients.google.com"
- "clients2.google.com"
- "contentautofill.googleapis.com"
- "safebrowsingohttpgateway.googleapis.com"
- "www.google.com"See Network Configuration for more information.
|
There was a problem hiding this comment.
💥 Automated smoke test review - all systems nominal!
Warning
Firewall blocked 6 domains
The following domains were blocked by the firewall during workflow execution:
accounts.google.comandroid.clients.google.comclients2.google.comcontentautofill.googleapis.comsafebrowsingohttpgateway.googleapis.comwww.google.com
To allow these domains, add them to the
network.allowedlist in your workflow frontmatter:
network:
allowed:
- defaults
- "accounts.google.com"
- "android.clients.google.com"
- "clients2.google.com"
- "contentautofill.googleapis.com"
- "safebrowsingohttpgateway.googleapis.com"
- "www.google.com"See Network Configuration for more information.
💥 [THE END] — Illustrated by Smoke Claude · opus47 7.6M
| include-hidden-files: true | ||
| path: | | ||
| /tmp/gh-aw/aw_info.json | ||
| /tmp/gh-aw/model_multipliers.json |
There was a problem hiding this comment.
💥 Smoke-test review comment — verifying model_multipliers.json is included in the activation artifact. Looks good!
| include-hidden-files: true | ||
| path: | | ||
| /tmp/gh-aw/aw_info.json | ||
| /tmp/gh-aw/model_multipliers.json |
There was a problem hiding this comment.
💥 Smoke-test review comment — confirming model_multipliers.json artifact-path entry is consistent across lock files.
|
@copilot merge main and recompile |
|
Smoke Copilot 26505735357: FAIL Warning Firewall blocked 5 domainsThe following domains were blocked by the firewall during workflow execution:
network:
allowed:
- defaults
- "accounts.google.com"
- "clients2.google.com"
- "contentautofill.googleapis.com"
- "safebrowsingohttpgateway.googleapis.com"
- "www.google.com"See Network Configuration for more information.
|
There was a problem hiding this comment.
Smoke review complete for run 26505735357.
Warning
Firewall blocked 5 domains
The following domains were blocked by the firewall during workflow execution:
accounts.google.comclients2.google.comcontentautofill.googleapis.comsafebrowsingohttpgateway.googleapis.comwww.google.com
To allow these domains, add them to the
network.allowedlist in your workflow frontmatter:
network:
allowed:
- defaults
- "accounts.google.com"
- "clients2.google.com"
- "contentautofill.googleapis.com"
- "safebrowsingohttpgateway.googleapis.com"
- "www.google.com"See Network Configuration for more information.
📰 BREAKING: Report filed by Smoke Copilot · gpt55 5.9M
| include-hidden-files: true | ||
| path: | | ||
| /tmp/gh-aw/aw_info.json | ||
| /tmp/gh-aw/model_multipliers.json |
There was a problem hiding this comment.
Smoke review note: this artifact path is present in the locked workflow, matching the file-based multiplier flow.
| export COPILOT_API_KEY="$COPILOT_DUMMY_BYOK" | ||
| (umask 177 && touch /tmp/gh-aw/agent-stdio.log) | ||
| printf '%s\n' '{"$schema":"https://github.com/github/gh-aw-firewall/releases/download/v0.25.55/awf-config.schema.json","network":{"allowDomains":["*.grafana.net","*.sentry.io","api.business.githubcopilot.com","api.enterprise.githubcopilot.com","api.github.com","api.githubcopilot.com","api.individual.githubcopilot.com","api.snapcraft.io","archive.ubuntu.com","azure.archive.ubuntu.com","crl.geotrust.com","crl.globalsign.com","crl.identrust.com","crl.sectigo.com","crl.thawte.com","crl.usertrust.com","crl.verisign.com","crl3.digicert.com","crl4.digicert.com","crls.ssl.com","github.com","host.docker.internal","json-schema.org","json.schemastore.org","keyserver.ubuntu.com","ocsp.digicert.com","ocsp.geotrust.com","ocsp.globalsign.com","ocsp.identrust.com","ocsp.sectigo.com","ocsp.ssl.com","ocsp.thawte.com","ocsp.usertrust.com","ocsp.verisign.com","packagecloud.io","packages.cloud.google.com","packages.microsoft.com","ppa.launchpad.net","raw.githubusercontent.com","registry.npmjs.org","s.symcb.com","s.symcd.com","security.ubuntu.com","telemetry.enterprise.githubcopilot.com","ts-crl.ws.symantec.com","ts-ocsp.ws.symantec.com","www.googleapis.com"]},"apiProxy":{"enabled":true,"enableTokenSteering":true,"maxRuns":500,"maxEffectiveTokens":25000000,"models":{"agent":["sonnet-6x","gpt-5.4","gpt-5.3","gemini-pro","any"],"antigravity":["copilot/antigravity*","google/antigravity*","gemini/antigravity*"],"any":["copilot/*","anthropic/*","openai/*","google/*","gemini/*"],"claude":["agent"],"codex":["agent"],"coding":["copilot/gpt-5*codex*","openai/gpt-5*codex*","gpt-5-codex"],"computer-use":["copilot/*computer-use*","google/*computer-use*","gemini/*computer-use*","openai/*computer-use*"],"copilot":["agent"],"deep-research":["copilot/deep-research*","copilot/o3-deep-research*","copilot/o4-mini-deep-research*","google/deep-research*","gemini/deep-research*","openai/o3-deep-research*","openai/o4-mini-deep-research*"],"gemini":["agent"],"gemini-3-flash":["copilot/gemini-3*flash*","google/gemini-3*flash*","gemini/gemini-3*flash*"],"gemini-3-pro":["copilot/gemini-3*pro*","google/gemini-3*pro*","gemini/gemini-3*pro*"],"gemini-3.1-flash":["copilot/gemini-3.1*flash*","google/gemini-3.1*flash*","gemini/gemini-3.1*flash*"],"gemini-3.1-pro":["copilot/gemini-3.1*pro*","google/gemini-3.1*pro*","gemini/gemini-3.1*pro*"],"gemini-3.5-flash":["copilot/gemini-3.5*flash*","google/gemini-3.5*flash*","gemini/gemini-3.5*flash*"],"gemini-flash":["copilot/gemini-*flash*","google/gemini-*flash*","gemini/gemini-*flash*"],"gemini-flash-lite":["copilot/gemini-*flash*lite*","google/gemini-*flash*lite*","gemini/gemini-*flash*lite*"],"gemini-pro":["copilot/gemini-*pro*","google/gemini-*pro*","gemini/gemini-*pro*"],"gemma":["copilot/gemma*","google/gemma*","gemini/gemma*"],"gpt-4.1":["copilot/gpt-4.1*","openai/gpt-4.1*"],"gpt-5":["copilot/gpt-5*","openai/gpt-5*"],"gpt-5-codex":["copilot/gpt-5*codex*","openai/gpt-5*codex*"],"gpt-5-mini":["copilot/gpt-5*mini*","openai/gpt-5*mini*"],"gpt-5-nano":["copilot/gpt-5*nano*","openai/gpt-5*nano*"],"gpt-5-pro":["copilot/gpt-5*pro*","openai/gpt-5*pro*"],"gpt-5.2":["copilot/gpt-5.2*","openai/gpt-5.2*"],"gpt-5.3":["copilot/gpt-5.3*","openai/gpt-5.3*"],"gpt-5.4":["copilot/gpt-5.4*","openai/gpt-5.4*"],"gpt-5.5":["copilot/gpt-5.5*","openai/gpt-5.5*"],"haiku":["copilot/*haiku*","anthropic/*haiku*"],"large":["sonnet","gpt-5-pro","gpt-5","gemini-pro"],"mini":["haiku","gpt-5-mini","gpt-5-nano","gemini-flash-lite"],"opus":["copilot/*opus*","anthropic/*opus*"],"opusplan":["opus?effort=high"],"reasoning":["copilot/o1*","copilot/o3*","copilot/o4*","openai/o1*","openai/o3*","openai/o4*"],"robotics":["copilot/*robotics*","google/*robotics*","gemini/*robotics*"],"small":["mini"],"sonnet":["copilot/*sonnet*","anthropic/*sonnet*"],"sonnet-6x":["copilot/*sonnet-4-5-*","anthropic/*sonnet-4-5-*","copilot/*sonnet-4-6*","anthropic/*sonnet-4-6*"],"summarization":["haiku","gpt-5-mini","gemini-flash-lite","mini"],"vision":["copilot/gemini-*image*","gemini/gemini-*image*","copilot/gemini-*flash*","gemini/gemini-*flash*"]}},"container":{"imageTag":"0.25.55"}}' > "${RUNNER_TEMP}/gh-aw/awf-config.json" | ||
| GH_AW_MODEL_MULTIPLIERS_PATH="/tmp/gh-aw/model_multipliers.json" node "${RUNNER_TEMP}/gh-aw/actions/merge_awf_model_multipliers.cjs" |
There was a problem hiding this comment.
Smoke review note: the merge script invocation is visible here, so the generated workflow carries the activation artifact path forward.
|
📰 VERDICT: Smoke Copilot has concluded. All systems operational. This is a developing story. 🎤 |
…aliases-and-multipliers # Conflicts: # .github/workflows/daily-compiler-threat-spec-optimizer.lock.yml Co-authored-by: pelikhan <4175913+pelikhan@users.noreply.github.com>
The compiler currently pushes merged model data through step environment variables, which bloats compiled logs and creates churn. This change shifts model multiplier/alias propagation to a file-based flow rooted in the activation artifact, so downstream jobs read the same materialized payload from disk.
Activation job now materializes merged model data
generate_aw_info.cjsnow builds/tmp/gh-aw/model_multipliers.jsonby merging:actions/setup/js/model_multipliers.json)engine.token-weights(GH_AW_INFO_TOKEN_WEIGHTS)/tmp/gh-aw/model_multipliers.json.Runtime ET/model logic now reads from artifact-backed file
effective_tokens.cjsnow resolves multipliers in deterministic order:/tmp/gh-aw/model_multipliers.json(activation artifact payload)GH_AW_MODEL_MULTIPLIERS(compatibility fallback)model_multipliers.jsonin setup scriptsSetup no longer injects large model JSON into job env
GH_AW_MODEL_MULTIPLIERSexport block fromactions/setup/setup.sh.Readability hardening in JS merge/parse paths
✨ PR Review Safe Output Test - Run 26431767267
Warning
Firewall blocked 6 domains
The following domains were blocked by the firewall during workflow execution:
accounts.google.comandroid.clients.google.comclients2.google.comcontentautofill.googleapis.comsafebrowsingohttpgateway.googleapis.comwww.google.comSee Network Configuration for more information.
pr-sous-chef: updated branch on https://github.com/github/gh-aw/actions/runs/26481536311
Updated branch with the latest base branch changes.
✨ PR Review Safe Output Test - Run 26505735356
Warning
Firewall blocked 6 domains
The following domains were blocked by the firewall during workflow execution:
accounts.google.comandroid.clients.google.comclients2.google.comcontentautofill.googleapis.comsafebrowsingohttpgateway.googleapis.comwww.google.comSee Network Configuration for more information.